fix: save logs to file instead of embedding in URL to avoid URL length errors #3422
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…h errors - Add tauri-plugin-fs dependency for file writing - Modify feedback modal to save logs to a file via save dialog - Update checkbox label to reflect new behavior - GitHub issue body now instructs user to attach the saved log file Co-Authored-By: john@hyprnote.com <john@hyprnote.com>
Contributor
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
✅ Deploy Preview for hyprnote-storybook ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for hyprnote ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When users tried to submit bug reports with logs attached, GitHub would show an error because the request URL was too long (logs were embedded directly in the URL query parameters).
This PR changes the approach: instead of embedding logs in the URL, users can now save logs to a local file via a native save dialog, then manually attach that file to the GitHub issue.
Changes:
tauri-plugin-fsfor file writing capabilitieshyprnote-logs-2024-01-27T10-30-00-000Z.txt)Review & Testing Checklist for Human
Recommended test plan:
Notes