Skip to content

Add error catch to the _handleSmsStatusReport function, fixes #56 #122

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
GraffJosh wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add error catch to the _handleSmsStatusReport function, fixes #56 #122

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions gsmmodem/modem.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1006,8 +1006,15 @@ def _handleSmsStatusReport(self, notificationLine):
if cdsiMatch:
msgMemory = cdsiMatch.group(1)
msgIndex = cdsiMatch.group(2)
report = self.readStoredSms(msgIndex, msgMemory)
self.deleteStoredSms(msgIndex)
try:
report = self.readStoredSms(msgIndex, msgMemory)
except:
#This handles an intermittent issue where the modem responds with a non-response like object.
self.log.error('Error during processing of SMS Status Report')
finally:
#It's probably best to delete the stored response since we couldn't process it effectively.
self.deleteStoredSms(msgIndex)
return
# Update sent SMS status if possible
if report.reference in self.sentSms:
self.sentSms[report.reference].report = report
Expand Down