Use multiply shift instead of u128 division to 2x encoding speed #25
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With some help from the quickdiv library, I have found the multiply and shift that is equivalent to a u128 division by 62^10. We currently do that division twice and its super super slow (
__udivti3). For u64 the compiler already turns the divisions into a multiply and shift which is why the use of mostly-u64-divisions in this library is so effective, but this is not the case for u128 apparently.