Conversation
There was a problem hiding this comment.
Pull Request Overview
This pull request adds .NET Aspire hosting support for the Azure Search Emulator, enabling developers to easily integrate the emulator into their Aspire applications. The changes include a new NuGet package F23.Aspire.Hosting.AzureSearchEmulator with extension methods for adding the emulator as a container resource, along with supporting test projects and a demo application.
Key changes:
- New Aspire hosting library with extension methods for adding Azure Search Emulator to Aspire applications
- Support for configuring HTTP/HTTPS endpoints and persistent volume for index data
- Demo AppHost project demonstrating both project-based and container-based usage patterns
- DebugClient updated to support configurable port numbers via command-line arguments
Reviewed Changes
Copilot reviewed 18 out of 19 changed files in this pull request and generated 9 comments.
Show a summary per file
| File | Description |
|---|---|
| logo.png | Added project logo for NuGet package branding |
| AzureSearchEmulator.Aspire/AzureSearchEmulatorResource.cs | Defines the container resource class with default port constants |
| AzureSearchEmulator.Aspire/AzureSearchEmulatorResourceExtensions.cs | Provides extension methods for adding and configuring the emulator in Aspire |
| AzureSearchEmulator.Aspire/AzureSearchEmulator.Aspire.csproj | Project file for the packable Aspire hosting library |
| AzureSearchEmulator.Aspire.Tests/*.cs | Unit tests validating resource creation and configuration |
| AzureSearchEmulator.Aspire.Tests/AzureSearchEmulator.Aspire.Tests.csproj | Test project configuration |
| AzureSearchEmulator.Aspire.DemoAppHost/. | Demo application demonstrating Aspire integration patterns |
| DebugClient/Program.cs | Enhanced with configurable port support for flexible testing |
| DebugClient/DebugClient.csproj | Marked as non-packable |
| AzureSearchEmulator/AzureSearchEmulator.csproj | Marked as non-packable |
| AzureSearchEmulator/Properties/launchSettings.json | Simplified launch profiles, removed unused IIS and Docker profiles |
| AzureSearchEmulator.IntegrationTests/AzureSearchEmulator.IntegrationTests.csproj | Marked as non-packable |
| AzureSearchEmulator.sln | Added three new projects to the solution |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #16