feat: show txid and fee for pending on-chain receives - #491
Open
FrankChinedu wants to merge 1 commit into
Open
Conversation
FrankChinedu
force-pushed
the
feat/pending-onchain-receive-details
branch
2 times, most recently
from
July 31, 2026 12:19
f656c9f to
e76df8a
Compare
Make the pending on-chain deposit card tappable, opening a detail sheet with amount, txid, and the peg-in fee breakdown, matching the existing detail view for completed transactions (fixes fedimint#479). Threads a `txid` field through the Mempool/AwaitingConfs/Confirmed/ Claimed deposit events on the Rust side rather than deriving it in Dart from the existing `outpoint` field. For walletv2, `outpoint` is actually the receive address, not `txid:vout` (the walletv2 event log identifies deposits by address), so parsing it client-side would have shown the wrong value for every walletv2 deposit, the default module for new gateways. The fee is surfaced as components (federation base fee, relative ppm rate, on-chain claim fee) rather than a single total, because walletv2 scales the federation fee with the deposit amount and adds a dynamic claim fee. This reuses the labels and formatting already used by the receive screen, so both read identically.
FrankChinedu
force-pushed
the
feat/pending-onchain-receive-details
branch
from
July 31, 2026 13:07
e76df8a to
f49c0e1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make the pending on-chain deposit card tappable, opening a detail sheet with amount, txid, and peg-in fee, matching the existing detail view for completed transactions (fixes #479).
Threads a
txidfield through the Mempool/AwaitingConfs/Confirmed/ Claimed deposit events on the Rust side rather than deriving it in Dart from the existingoutpointfield. For walletv2,outpointis actually the receive address, nottxid:vout(the walletv2 event log identifies deposits by address), so parsing it client-side would have shown the wrong value for every walletv2 deposit, the default module for new gateways.