Skip to content

fix: parse fee value with html tags#105

Merged
felipeall merged 1 commit intomainfrom
102-transfer-history-fails-to-parse-fee
Apr 13, 2025
Merged

fix: parse fee value with html tags#105
felipeall merged 1 commit intomainfrom
102-transfer-history-fails-to-parse-fee

Conversation

@felipeall
Copy link
Owner

@felipeall felipeall commented Apr 13, 2025

Summary by CodeRabbit

  • New Features
    • Enhanced parsing of monetary values: Inputs with embedded HTML are now accurately processed to extract and convert values expressed in various scales (thousands, millions, or billions).

@felipeall felipeall linked an issue Apr 13, 2025 that may be closed by this pull request
@coderabbitai
Copy link

coderabbitai bot commented Apr 13, 2025

Caution

Review failed

The pull request is closed.

Walkthrough

The pull request enhances the parse_str_to_int method in the TransfermarktBaseModel class by introducing logic to handle input strings containing HTML tags. When a "<" character is detected in the string, the method applies a regular expression to extract a euro-prefixed monetary value, returning None if no match is found. If no HTML is present, the method continues with the usual cleaning process, removing characters such as "€", "+", and "'" and converting suffixes (like "k", "m", "bn", or "b") into their integer representations.

Changes

File(s) Change Summary
app/schemas/base.py Modified the parse_str_to_int method to check for HTML tags. If a "<" is present, the method uses regex to extract a euro-prefixed number. Otherwise, it continues with the original cleaning and conversion logic for handling suffix multipliers.

Sequence Diagram(s)

sequenceDiagram
  participant Caller
  participant Model as TransfermarktBaseModel.parse_str_to_int
  Caller->>Model: Call with input string v
  alt v contains "<"
    Model->>Model: Apply regex to find "€" value
    alt Regex match found
      Model-->>Caller: Return converted monetary value
    else No match found
      Model-->>Caller: Return None
    end
  else No HTML tag
    Model->>Model: Remove unwanted characters (€, +, ')
    Model->>Model: Process suffix multipliers (k, m, bn, b)
    Model-->>Caller: Return converted integer value
  end
Loading

Poem

Hi, I'm a coding rabbit, hopping through the night,
Fixing HTML hiccups and making everything right.
Regex hops in quick like a breeze so fine,
Turning euros in text to numbers in line.
I nibble on code bugs with joyful delight,
Celebrating the changes from morning 'til night!

Tip

⚡💬 Agentic Chat (Pro Plan, General Availability)
  • We're introducing multi-step agentic chat in review comments and issue comments, within and outside of PR's. This feature enhances review and issue discussions with the CodeRabbit agentic chat by enabling advanced interactions, including the ability to create pull requests directly from comments and add commits to existing pull requests.

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 1277864 and fe13552.

📒 Files selected for processing (1)
  • app/schemas/base.py (2 hunks)
✨ Finishing Touches
  • 📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai plan to trigger planning for file edits and PR creation.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@felipeall felipeall merged commit bee4c49 into main Apr 13, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Transfer history fails to parse fee

1 participant

Comments