Skip to content

vp migrate#27

Draft
fengmk2 wants to merge 3 commits into
mainfrom
vp-migrate-test-v2
Draft

vp migrate#27
fengmk2 wants to merge 3 commits into
mainfrom
vp-migrate-test-v2

Conversation

@fengmk2

@fengmk2 fengmk2 commented Jul 1, 2026

Copy link
Copy Markdown
Owner

🔗 Linked issue

🧭 Context

📚 Description

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request migrates dependency management to pnpm catalogs, updates the CLI build script to use vite-plus instead of tsdown, and adds a registry bridge to .npmrc. The review feedback recommends adding vite-plus to the CLI package's devDependencies to support independent builds, and pinning the playwright dependency version instead of using a wildcard to prevent non-deterministic builds.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread cli/package.json
"@types/node": "24.12.2",
"@types/validate-npm-package-name": "4.0.2",
"tsdown": "0.21.7",
"typescript": "6.0.2"

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Since the build script in cli/package.json has been updated to use vp pack (which is provided by vite-plus), vite-plus should be added to the devDependencies of this package. This ensures that the package can be built independently within the workspace without relying solely on root-level hoisting.

    "typescript": "6.0.2",
    "vite-plus": "catalog:"

Comment thread package.json Outdated
"markdown-it-anchor": "9.2.0",
"msw": "catalog:msw",
"msw-storybook-addon": "catalog:storybook",
"playwright": "*",

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Using * for the playwright dependency version can lead to non-deterministic builds and potential compatibility issues. Since @playwright/test is pinned to 1.60.0 on line 122, it is highly recommended to pin playwright to the same version (1.60.0) to ensure compatibility between the test runner and the browser binaries.

Suggested change
"playwright": "*",
"playwright": "1.60.0",

Comment thread package.json Outdated
"@types/validate-npm-package-name": "4.0.2",
"@vitest/coverage-v8": "4.1.6",
"@vitest/browser-playwright": "4.1.9",
"@vitest/coverage-v8": "4.1.9",

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vitest/* packages should be use catalog too? just like vitest.

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, there is a real inconsistency:

  • @vitest/browser-playwright: the migrate did add it to your default catalog: (pnpm-workspace.yaml), but wrote it as concrete 4.1.9 here instead of catalog:, so that catalog entry is unused. It should be catalog: (a bug).
  • @vitest/coverage-v8: it stays concrete because it was concrete before and no catalog owned it. The migrate only aligns existing catalog references; it does not move a concrete dep into a catalog. Since your toolchain is fully catalog-managed, it arguably should be catalog'd too for consistency.

Filed voidzero-dev/vite-plus#2005 to fix the provider reference and to reconsider catalog-izing aligned @vitest/*. For now you can set both to catalog: and add @vitest/coverage-v8: 4.1.9 to the catalog.

@github-actions

github-actions Bot commented Jul 1, 2026

Copy link
Copy Markdown

e18e dependency analysis

No dependency warnings found.

@fengmk2 fengmk2 force-pushed the vp-migrate-test-v2 branch from a9b8182 to d53b6b2 Compare July 1, 2026 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant