vp migrate#27
Conversation
There was a problem hiding this comment.
Code Review
This pull request migrates dependency management to pnpm catalogs, updates the CLI build script to use vite-plus instead of tsdown, and adds a registry bridge to .npmrc. The review feedback recommends adding vite-plus to the CLI package's devDependencies to support independent builds, and pinning the playwright dependency version instead of using a wildcard to prevent non-deterministic builds.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
| "@types/node": "24.12.2", | ||
| "@types/validate-npm-package-name": "4.0.2", | ||
| "tsdown": "0.21.7", | ||
| "typescript": "6.0.2" |
There was a problem hiding this comment.
Since the build script in cli/package.json has been updated to use vp pack (which is provided by vite-plus), vite-plus should be added to the devDependencies of this package. This ensures that the package can be built independently within the workspace without relying solely on root-level hoisting.
"typescript": "6.0.2",
"vite-plus": "catalog:"| "markdown-it-anchor": "9.2.0", | ||
| "msw": "catalog:msw", | ||
| "msw-storybook-addon": "catalog:storybook", | ||
| "playwright": "*", |
There was a problem hiding this comment.
Using * for the playwright dependency version can lead to non-deterministic builds and potential compatibility issues. Since @playwright/test is pinned to 1.60.0 on line 122, it is highly recommended to pin playwright to the same version (1.60.0) to ensure compatibility between the test runner and the browser binaries.
| "playwright": "*", | |
| "playwright": "1.60.0", |
| "@types/validate-npm-package-name": "4.0.2", | ||
| "@vitest/coverage-v8": "4.1.6", | ||
| "@vitest/browser-playwright": "4.1.9", | ||
| "@vitest/coverage-v8": "4.1.9", |
There was a problem hiding this comment.
@vitest/* packages should be use catalog too? just like vitest.
There was a problem hiding this comment.
Good catch, there is a real inconsistency:
@vitest/browser-playwright: the migrate did add it to your defaultcatalog:(pnpm-workspace.yaml), but wrote it as concrete4.1.9here instead ofcatalog:, so that catalog entry is unused. It should becatalog:(a bug).@vitest/coverage-v8: it stays concrete because it was concrete before and no catalog owned it. The migrate only aligns existing catalog references; it does not move a concrete dep into a catalog. Since your toolchain is fully catalog-managed, it arguably should be catalog'd too for consistency.
Filed voidzero-dev/vite-plus#2005 to fix the provider reference and to reconsider catalog-izing aligned @vitest/*. For now you can set both to catalog: and add @vitest/coverage-v8: 4.1.9 to the catalog.
e18e dependency analysisNo dependency warnings found. |
8b93c88 to
a9b8182
Compare
a9b8182 to
d53b6b2
Compare
🔗 Linked issue
🧭 Context
📚 Description