vp migrate beta test#9
Conversation
There was a problem hiding this comment.
Code Review
This pull request primarily migrates the testing framework imports from vitest to vite-plus/test across all test suites and adds VoidZero.vite-plus-extension-pack to the VS Code recommended extensions. It also applies extensive code formatting and style updates to React components, hooks, utilities, and Drizzle database schema snapshots. No review comments were provided, so there is no additional feedback to address.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
| minimumReleaseAge = 259200 | ||
| minimumReleaseAgeExcludes = ["@zerobyte/*"] | ||
| minimumReleaseAgeExcludes = | ||
| peer = false |
| "packageManager": "bun@1.3.14" | ||
| "packageManager": "bun@1.3.14", | ||
| "catalog": { | ||
| "vite": "8.1.0", |
There was a problem hiding this comment.
bun don't support using @voidzero-dev/vite-plus-core overrides vite, it strictly verifies that the package name must be vite to be overridden.
`peer = false` does not disable peer validation when a provider is explicitly present.
Migration creates:
"catalog": {
"vite": "https://.../@voidzero-dev/vite-plus-core@..."
},
"devDependencies": {
"vite": "catalog:"
},
"overrides": {
"vite": "catalog:"
}
Bun resolves that provider, sees its real identity/version is `@voidzero-dev/vite-plus-core@0.x`,
and rejects it for Vitest’s required `vite@^6 || ^7 || ^8` peer.
I verified with Bun 1.3.14:
- Core-backed Vite catalog plus `peer = false`: fails.
- Real `vite@^8.0.16` catalog without the Vite override: succeeds.
The production fix is therefore to preserve real Vite for Bun, omit `overrides.vite`, and stop
adding `peer = false`. Vite+ itself will continue using Vite+ Core internally.There was a problem hiding this comment.
why this works?
{
"devDependencies": {
"vite": "npm:@voidzero-dev/vite-plus-core@0.2.1",
"vite-plus": "0.2.1",
"@voidzero-dev/vite-plus-core": "0.2.1"
},
"overrides": {
"vite": "npm:@voidzero-dev/vite-plus-core@0.2.1"
},
"scripts": {
"dev": "vp dev",
"build": "vp build",
"preview": "vp preview",
"check": "vp check"
},
"devEngines": {
"packageManager": {
"name": "bun",
"version": "1.3.14",
"onFail": "download"
}
}
}There was a problem hiding this comment.
Please implement a workaround in the current Bun project so that a Vite+ PR build from pkg.pr.new can override vite through Bun overrides.
Goal:
Download this package:
https://pkg.pr.new/voidzero-dev/vite-plus/@voidzero-dev/vite-plus-core@1891
Repack it as a local tarball whose internal package.json.name is "vite", then configure Bun overrides like this:
"overrides": {
"vite": "file:./vendor/vite-plus-core-as-vite-1891.tgz"
}
Please add scripts/repack-vite-pr.sh. The script should accept a PR number or commit SHA as the first argument, defaulting to 1891.
It should:
- Download https://pkg.pr.new/voidzero-dev/vite-plus/@voidzero-dev/vite-plus-core@$PR
- Extract the tarball.
- Change package.json.name to "vite".
- Set package.json.version to bundledVersions.vite if available, otherwise "8.0.0".
- Preserve existing dependencies.
- Add these dependencies:
"@voidzero-dev/vite-plus-core": "https://pkg.pr.new/voidzero-dev/vite-plus/@voidzero-dev/vite-plus-core@$PR"
"vite-plus": "https://pkg.pr.new/voidzero-dev/vite-plus/vite-plus@$PR" - Repack the modified package into vendor/vite-plus-core-as-vite-$PR.tgz.
- Print the generated tarball path.
Then update package.json so devDependencies include:
"vite": "file:./vendor/vite-plus-core-as-vite-1891.tgz",
"@voidzero-dev/vite-plus-core": "https://pkg.pr.new/voidzero-dev/vite-plus/@voidzero-dev/vite-plus-core@1891",
"vite-plus": "https://pkg.pr.new/voidzero-dev/vite-plus/vite-plus@1891"
Also set:
"overrides": {
"vite": "file:./vendor/vite-plus-core-as-vite-1891.tgz"
}
If existing scripts use vite dev/build/preview, migrate them to vp dev, vp build, and vp preview. Add vp check if appropriate.
After implementation, run:
rm -rf node_modules bun.lock
bun install
bun why vite
bun why @voidzero-dev/vite-plus-core
node -p "require('./node_modules/vite/package.json').name"
node -p "require('./node_modules/vite/package.json').version"
node -p "require('./node_modules/@voidzero-dev/vite-plus-core/package.json').name"
bunx vp check
bunx vp build
Expected:
- node_modules/vite/package.json has name "vite".
- node_modules/@voidzero-dev/vite-plus-core/package.json has name "@voidzero-dev/vite-plus-core".
- Bun resolves vite through the local repacked tarball.
ab9e109 to
258bf1d
Compare
No description provided.