Skip to content

vp migrate beta test#9

Draft
fengmk2 wants to merge 2 commits into
mainfrom
vp-migrate-test
Draft

vp migrate beta test#9
fengmk2 wants to merge 2 commits into
mainfrom
vp-migrate-test

Conversation

@fengmk2

@fengmk2 fengmk2 commented Jun 25, 2026

Copy link
Copy Markdown
Owner

No description provided.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request primarily migrates the testing framework imports from vitest to vite-plus/test across all test suites and adds VoidZero.vite-plus-extension-pack to the VS Code recommended extensions. It also applies extensive code formatting and style updates to React components, hooks, utilities, and Drizzle database schema snapshots. No review comments were provided, so there is no additional feedback to address.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread bunfig.toml Outdated
minimumReleaseAge = 259200
minimumReleaseAgeExcludes = ["@zerobyte/*"]
minimumReleaseAgeExcludes =
peer = false

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why add peer = false?

Comment thread package.json Outdated
"packageManager": "bun@1.3.14"
"packageManager": "bun@1.3.14",
"catalog": {
"vite": "8.1.0",

@fengmk2 fengmk2 Jun 26, 2026

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bun don't support using @voidzero-dev/vite-plus-core overrides vite, it strictly verifies that the package name must be vite to be overridden.

`peer = false` does not disable peer validation when a provider is explicitly present.

  Migration creates:

  
  "catalog": {
    "vite": "https://.../@voidzero-dev/vite-plus-core@..."
  },
  "devDependencies": {
    "vite": "catalog:"
  },
  "overrides": {
    "vite": "catalog:"
  }
 

  Bun resolves that provider, sees its real identity/version is `@voidzero-dev/vite-plus-core@0.x`,
  and rejects it for Vitest’s required `vite@^6 || ^7 || ^8` peer.

  I verified with Bun 1.3.14:

  - Core-backed Vite catalog plus `peer = false`: fails.
  - Real `vite@^8.0.16` catalog without the Vite override: succeeds.

  The production fix is therefore to preserve real Vite for Bun, omit `overrides.vite`, and stop
  adding `peer = false`. Vite+ itself will continue using Vite+ Core internally.

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why this works?

{
  "devDependencies": {
    "vite": "npm:@voidzero-dev/vite-plus-core@0.2.1",
    "vite-plus": "0.2.1",
    "@voidzero-dev/vite-plus-core": "0.2.1"
  },
  "overrides": {
    "vite": "npm:@voidzero-dev/vite-plus-core@0.2.1"
  },
  "scripts": {
    "dev": "vp dev",
    "build": "vp build",
    "preview": "vp preview",
    "check": "vp check"
  },
  "devEngines": {
    "packageManager": {
      "name": "bun",
      "version": "1.3.14",
      "onFail": "download"
    }
  }
}

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please implement a workaround in the current Bun project so that a Vite+ PR build from pkg.pr.new can override vite through Bun overrides.

Goal:
Download this package:

https://pkg.pr.new/voidzero-dev/vite-plus/@voidzero-dev/vite-plus-core@1891

Repack it as a local tarball whose internal package.json.name is "vite", then configure Bun overrides like this:

"overrides": {
"vite": "file:./vendor/vite-plus-core-as-vite-1891.tgz"
}

Please add scripts/repack-vite-pr.sh. The script should accept a PR number or commit SHA as the first argument, defaulting to 1891.

It should:

Then update package.json so devDependencies include:

"vite": "file:./vendor/vite-plus-core-as-vite-1891.tgz",
"@voidzero-dev/vite-plus-core": "https://pkg.pr.new/voidzero-dev/vite-plus/@voidzero-dev/vite-plus-core@1891",
"vite-plus": "https://pkg.pr.new/voidzero-dev/vite-plus/vite-plus@1891"

Also set:

"overrides": {
"vite": "file:./vendor/vite-plus-core-as-vite-1891.tgz"
}

If existing scripts use vite dev/build/preview, migrate them to vp dev, vp build, and vp preview. Add vp check if appropriate.

After implementation, run:

rm -rf node_modules bun.lock
bun install
bun why vite
bun why @voidzero-dev/vite-plus-core
node -p "require('./node_modules/vite/package.json').name"
node -p "require('./node_modules/vite/package.json').version"
node -p "require('./node_modules/@voidzero-dev/vite-plus-core/package.json').name"
bunx vp check
bunx vp build

Expected:

  • node_modules/vite/package.json has name "vite".
  • node_modules/@voidzero-dev/vite-plus-core/package.json has name "@voidzero-dev/vite-plus-core".
  • Bun resolves vite through the local repacked tarball.

@fengmk2 fengmk2 force-pushed the vp-migrate-test branch 2 times, most recently from ab9e109 to 258bf1d Compare June 26, 2026 06:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant