Fix: freeze recently liked v2 enrollment - #334
Merged
Merged
Conversation
Member
Author
|
STAFF ENGINEER REVIEW: APPROVED — clean structural review. Freeze gate is placed after existing assignment lookup and before metrics/assignment insert, preserving existing variants while preventing new enrollment; new unassigned mature users fall back to control weights without experiment rows. Local targeted tests passed: tests/recommendations/test_blender_experiments.py 16/16. Codex review found no P1 issues. CI lint/test are green. |
Member
Author
|
✅ Approved + merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes FFM-1917.
What changed
recently_liked_blender_v2new enrollment after the existing assignment read.Root cause
The assignment path still inserted new
recently_liked_blender_v2experiment rows after the July 22 checkpoint showed the 1,000-per-arm gate was no longer reachable in a useful window.Freeze record
2026-07-23T18:05:54ZproductionRECENTLY_LIKED_BLENDER_V2_ENROLLMENT_FROZEN = Falseand redeploy.Validation
ruff check --fix src/ tests/ruff format src/ tests/env DATABASE_URL=postgresql+asyncpg://postgres:postgres@localhost:65432/postgres REDIS_URL=redis://localhost:36379/0 CORS_ORIGINS='["*"]' CORS_HEADERS='["*"]' TELEGRAM_BOT_TOKEN=test TELEGRAM_BOT_USERNAME=test_bot TELEGRAM_BOT_WEBHOOK_SECRET=test MEME_STORAGE_TELEGRAM_CHAT_ID=1 UPLOADED_MEMES_REVIEW_CHAT_ID=2 ADMIN_LOGS_CHAT_ID=3 ENVIRONMENT=testing python3 -m pytest tests/recommendations/test_blender_experiments.py -qReviewer notes
Staff Engineer should verify the gate placement preserves existing assignments and does not touch cold-start routing,
cold_start_candidate_filter, moderator low-sent quota, or unrelated engines. FFM-1918 remains the Analyst post-deploy passive watch.