Fixed ff_draft.flea_conn to work again#411
Fixed ff_draft.flea_conn to work again#411RandalMorris wants to merge 2 commits intoffverse:mainfrom
Conversation
R/flea_draft.R
Outdated
| "player_name" = "nameFull", | ||
| "pos" = "position", | ||
| "team" = "proTeamAbbreviation") %>% | ||
| tidyr::hoist("slot", "pick_no" = "slot", "overall") %>% |
There was a problem hiding this comment.
I believe this was previously called pick and not pick_no (see the old code that this is replacing)
|
Looking into this - seems like this is now causing some tests to fail. Can you provide a couple sample flea league_ids ? |
Weird. Here are a few. 124676 140922 140974 140975 156396 158057 |
|
Asked around and it doesn’t seem like there’s a systematic reason as to why some leagues return the old format or the newer one. Super strange. I’ll probably need to implement some kind of conditional logic based on the API returns which is a very ugly approach but better than anything I can think of atm 🫠 |
|
It is Flea being Flea. For the Draft data. 131 leagues returned the same format this year. For some reason the sole league who took Kelce at #1 overall returned something different. I didn't look at the 1 league. Just filtered it out on the list lol. Possibly a check that the formats are different on in the top level and either do the import that way or a message saying you're league isn't supported due to the data. |
2 participants
Fixed pulling draft data for a league from Fleaflicker not working.