fix: Navigation group enum respects collapsible() when collapsed#20055
Open
people-sea wants to merge 2 commits into
Open
fix: Navigation group enum respects collapsible() when collapsed#20055people-sea wants to merge 2 commits into
collapsible() when collapsed#20055people-sea wants to merge 2 commits into
Conversation
danharrin
requested changes
Jun 19, 2026
danharrin
left a comment
danharrin
left a comment
Member
There was a problem hiding this comment.
Would you mind adding a regression test for this please?
…when `collapsed`
Member
Author
|
Done, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes: #20054
collapsed()also sets the collapsible state, so calling it aftercollapsible()infromEnum()overwrote the enum'sisCollapsible(). Swap the order.Visual changes
Before
After
Functional changes
composer cscommand.