CMake: Improve building without hunter#601
Merged
turuslan merged 3 commits intofilecoin-project:masterfrom Feb 22, 2022
Merged
Conversation
24 tasks
Codecov Report
@@ Coverage Diff @@
## master #601 +/- ##
=======================================
Coverage 46.02% 46.02%
=======================================
Files 715 715
Lines 32328 32328
Branches 17885 17885
=======================================
Hits 14880 14880
Misses 13102 13102
Partials 4346 4346 Continue to review full report at Codecov.
|
turuslan
approved these changes
Feb 21, 2022
Alexey-N-Chernyshov
approved these changes
Feb 21, 2022
Contributor
|
@eigendude, thanks for your interest and cooperation. |
Contributor
Author
|
@Alexey-N-Chernyshov thanks for accepting any of the patches. I get crazy ideas like bringing Filecoin to the living room and start to make them. Anything accepted means I don't have to do it twice 🙃 |
Markuu-s
pushed a commit
that referenced
this pull request
Mar 3, 2022
Signed-off-by: Garrett Brown <eigendude@gmail.com>
Markuu-s
pushed a commit
that referenced
this pull request
Mar 10, 2022
Signed-off-by: Garrett Brown <eigendude@gmail.com>
Markuu-s
pushed a commit
that referenced
this pull request
Mar 10, 2022
Signed-off-by: Garrett Brown <eigendude@gmail.com>
Markuu-s
pushed a commit
that referenced
this pull request
Mar 10, 2022
Signed-off-by: Garrett Brown <eigendude@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the Change
Now that #128 is merged, I've got Fuhon building without hunter again.
The approach is to delegate finding dependencies to the build system using the typical CMake approach, using find modules. I've included three find modules in this PR.
I only included find modules for three of the dependencies. The reason is because downstream, I just use the hunterized versions of dependencies. However, the hunter team made the unfortunate but easy choice of forking repos. This means that many dependencies have fallen behind the versions used by my team's app. We can't downgrade three of the packages, so I wrote CMake find modules for these three dependencies.
The final patch, for filecoin_ffi, also means that git submodules are no longer needed. This is advantageous, because git submodules cause problems for a fair number of build systems and packagers. And who hasn't forgotten
--recursive.It's an open question if we want CMake find modules for any additional dependencies. I could possibly add this to my List Of Things To Do (tm).
Benefits
Possible Drawbacks
CMake code is added, currently totaling about 70 lines. Normally any lines added increases the load of maintenance, but code that doesn't ship has much less of an impact.
Alternate Designs [optional]
I currently use an alternative approach for the Curl dependency - I just patch out the
CONFIGparameter, and ship the patch with the rest of my work. The exact patch is:By not including Curl in this PR, it increases my downstream technical debt, but not significantly.