Open
Conversation
📝 WalkthroughWalkthroughAdded a new "User Groups" documentation page and updated the Fillout docs navigation to include it under Account > Team Collaboration. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@user-groups.mdx`:
- Around line 30-39: The opening sentence currently claims groups can have "Use
or Edit permissions on workspaces or individual forms, apps, or databases" but
the Info block says "Use" isn't implemented for databases; update the lead
sentence to remove ambiguity by stating that Use/Edit apply to workspaces and to
individual forms and apps, and that databases only support Edit (or that Use for
databases is not implemented). Edit the sentence and, if helpful, clarify the
Info block to match this wording so the document consistently indicates
databases do not support Use permissions.
- Around line 23-25: The step titled "Add members & change permissions" uses
mixed references ("each group" / "their" / "this group") which is confusing;
update the copy in that Step so pronouns are consistent (either singular or
plural) — e.g. change to a single, clear sentence such as using "a group" +
"its" or "groups" + "their"; locate the Step element with title "Add members &
change permissions" and replace the existing sentence accordingly.
There was a problem hiding this comment.
♻️ Duplicate comments (2)
user-groups.mdx (2)
23-25:⚠️ Potential issue | 🟡 MinorTighten the Step copy for consistency and readability.
Line [24] is still a bit awkward (“a group” / “this group”) and can be simplified.
✍️ Suggested wording
- Using the dropdown menu on a group you can manage members or change the permissions of this group. + Use a group’s dropdown menu to manage members or update that group’s permissions.🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@user-groups.mdx` around lines 23 - 25, The Step titled "Add members & change permissions" has inconsistent phrasing ("a group" vs "this group"); change the copy to a single, concise sentence for clarity—locate the Step with title "Add members & change permissions" in user-groups.mdx and replace the body text with a tightened, consistent version such as "Use the group's dropdown menu to manage members and update permissions." Ensure punctuation and capitalization match surrounding Steps.
30-39:⚠️ Potential issue | 🟡 MinorResolve database permission ambiguity in the lead sentence.
Line [30] implies Use applies to databases, while Line [38] says it is not implemented. Make the scope explicit in the first sentence.
🧩 Suggested wording
-Groups can have **Use** or **Edit** permissions on workspaces or individual forms, apps, or databases within a workspace. +Groups can have **Use** or **Edit** permissions on workspaces, forms, and apps. For databases, only **Edit** is currently supported.🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@user-groups.mdx` around lines 30 - 39, Update the lead sentence that currently reads "Groups can have **Use** or **Edit** permissions on workspaces or individual forms, apps, or databases" to explicitly exclude databases for the **Use** permission (for example: "Groups can have **Use** or **Edit** permissions on workspaces or individual forms and apps (Use does not apply to databases)"). Keep the rest of the bullets for **Use** and **Edit** unchanged and ensure the existing <Info> block that states "Use permissions are currently not implemented on databases" remains consistent with the revised lead sentence so there is no ambiguity between the opening sentence and the Info note.
🧹 Nitpick comments (1)
user-groups.mdx (1)
3-8: Align the feature scope between summary and body.Line [3] and Line [8] frame access as workspace/forms only, but later sections include apps and databases. Consider aligning the opening copy to match the full scope documented below.
✍️ Suggested wording
-description: "Create groups to manage workspace and form access for multiple team members at once." +description: "Create groups to manage workspace access and permissions for forms, apps, and databases for multiple team members at once." -User Groups let admins bundle team members together and grant them workspace or form access all at once. +User Groups let admins bundle team members together and grant workspace, form, app, and database access all at once.🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@user-groups.mdx` around lines 3 - 8, Update the top-level description and opening paragraph for "User Groups" so the feature scope matches later sections: include apps and databases alongside workspace and form access (e.g., change the description value and the opening sentence under the "User Groups" heading to mention workspace, forms, apps, and databases), ensuring the sidebarTitle "User Groups" and icon remain unchanged.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Duplicate comments:
In `@user-groups.mdx`:
- Around line 23-25: The Step titled "Add members & change permissions" has
inconsistent phrasing ("a group" vs "this group"); change the copy to a single,
concise sentence for clarity—locate the Step with title "Add members & change
permissions" in user-groups.mdx and replace the body text with a tightened,
consistent version such as "Use the group's dropdown menu to manage members and
update permissions." Ensure punctuation and capitalization match surrounding
Steps.
- Around line 30-39: Update the lead sentence that currently reads "Groups can
have **Use** or **Edit** permissions on workspaces or individual forms, apps, or
databases" to explicitly exclude databases for the **Use** permission (for
example: "Groups can have **Use** or **Edit** permissions on workspaces or
individual forms and apps (Use does not apply to databases)"). Keep the rest of
the bullets for **Use** and **Edit** unchanged and ensure the existing <Info>
block that states "Use permissions are currently not implemented on databases"
remains consistent with the revised lead sentence so there is no ambiguity
between the opening sentence and the Info note.
---
Nitpick comments:
In `@user-groups.mdx`:
- Around line 3-8: Update the top-level description and opening paragraph for
"User Groups" so the feature scope matches later sections: include apps and
databases alongside workspace and form access (e.g., change the description
value and the opening sentence under the "User Groups" heading to mention
workspace, forms, apps, and databases), ensuring the sidebarTitle "User Groups"
and icon remain unchanged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add documentation for the upcoming user group feature.
Summary by CodeRabbit