Merged
Conversation
Collaborator
mattiaswal
commented
Feb 10, 2026
- Fix deletion of device node conditions
- Add a reconf handler in devmon to not leave device node conditons in flux
Only compare the beginning of the condition, not the whole condition name. Signed-off-by: Mattias Walström <lazzer@gmail.com>
Device conditions tracked by devmon were lost on `initctl reload` because the reconf path did not re-assert them. Add devmon_reconf() to iterate all tracked device nodes and set or clear their conditions based on current device presence. Signed-off-by: Mattias Walström <lazzer@gmail.com>
d85cbd4 to
b206c3d
Compare
troglobit
approved these changes
Feb 10, 2026
Collaborator
troglobit
left a comment
There was a problem hiding this comment.
Looks great, nice work! 💪
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.