Skip to content

Fixed an issue with passing arguments to windows OS #60

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
isvoker wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

Fixed an issue with passing arguments to windows OS #60

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
957ad0f
Fixed an issue with passing arguments to windows OS
isvoker Jan 27, 2025
25cd2db
Fixed an issue with passing arguments to windows OS
isvoker Jan 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 9 additions & 6 deletions warp-runner/src/executor.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,8 @@ use std::os::unix::fs::PermissionsExt;
use std::path::Path;
use std::process::Command;
use std::process::Stdio;
#[cfg(target_family = "windows")]
use std::os::windows::process::CommandExt;

pub fn execute(target: &Path) -> io::Result<i32> {
trace!("target={:?}", target);
Expand Down Expand Up @@ -54,13 +56,14 @@ fn do_execute(target: &Path, args: &[String]) -> io::Result<i32> {
let target_str = target.as_os_str().to_str().unwrap();

if is_script(target) {
let mut cmd_args = Vec::with_capacity(args.len() + 2);
cmd_args.push("/c".to_string());
cmd_args.push(target_str.to_string());
cmd_args.extend_from_slice(&args);

let mut cmd = format!(r#""{target_str}""#);
for arg in args {
cmd.push_str(&format!(" \"{}\"", arg));
}
trace!("cmd={:?}", cmd);
Ok(Command::new("cmd")
.args(cmd_args)
.arg("/c")
.raw_arg(format!("\"{}\"", cmd))
.stdin(Stdio::inherit())
.stdout(Stdio::inherit())
.stderr(Stdio::inherit())
Expand Down