Skip to content

chore: resolve formatting#662

Closed
SelaseKay wants to merge 2 commits into
firebase:mainfrom
SelaseKay:fix-format
Closed

chore: resolve formatting#662
SelaseKay wants to merge 2 commits into
firebase:mainfrom
SelaseKay:fix-format

Conversation

@SelaseKay

Copy link
Copy Markdown
Contributor

Description

Replace this paragraph with a description of what this PR is doing. If you're modifying existing behavior, describe the existing behavior, how this PR is changing it, and what motivated the change.

Related Issues

Replace this paragraph with a list of issues related to this PR from the issue database. Indicate, which of these issues are resolved or fixed by this PR.

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]).
This will ensure a smooth and quick review process. Updating the pubspec.yaml and changelogs is not required.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (melos run analyze) does not report any problems on my PR.
  • All unit tests pass (melos run test:unit:all doesn't fail).
  • I read and followed the Flutter Style Guide.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change.
  • No, this is not a breaking change.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request performs minor formatting and code style cleanups across several example projects, including adjusting spacing in Kotlin class declarations, reordering Swift imports, and wrapping long lines. The review feedback suggests a more idiomatic Swift approach in AppDelegate.swift by using NotificationCenter.default.post(name:object:userInfo:) directly and simplifying the Notification.Name initialization.

Comment on lines +15 to +16
NotificationCenter.default.post(
Notification(name: Notification.Name(rawValue: "linkReceived"), object: nil, userInfo: data))

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Instead of manually constructing a Notification object and passing it to post(_:), it is more idiomatic in Swift to use post(name:object:userInfo:) directly. Additionally, Notification.Name("linkReceived") is preferred over Notification.Name(rawValue: "linkReceived") for cleaner and more readable code.

    NotificationCenter.default.post(name: Notification.Name("linkReceived"), object: nil, userInfo: data)

@SelaseKay SelaseKay closed this Jul 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant