Skip to content

Change Firestore CI#15685

Merged
cherylEnkidu merged 37 commits intomainfrom
cheryl/changeFirestoreCi
Feb 5, 2026
Merged

Change Firestore CI#15685
cherylEnkidu merged 37 commits intomainfrom
cheryl/changeFirestoreCi

Conversation

@cherylEnkidu
Copy link
Copy Markdown
Contributor

@cherylEnkidu cherylEnkidu commented Jan 7, 2026

#no-changelog

PR Title: Fix Firestore Enterprise CI hangs & Add Enterprise Integration Tests

Description

This PR addresses persistent timeouts in FirestoreEnterprise jobs caused by resource exhaustion (OOM) on GitHub runners and expands Enterprise test coverage.

Changes

  • CI Stability: Throttled xcodebuild concurrency (-jobs 4) and split execution into separate build-for-testing and test-without-building steps. This prevents memory contention between the compiler and the Firestore Emulator.
  • New Tests: Added dedicated Enterprise integration test schemes for iOS, macOS, and tvOS.

@cherylEnkidu cherylEnkidu requested a review from a team as a code owner January 7, 2026 18:43
@gemini-code-assist
Copy link
Copy Markdown
Contributor

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

Copy link
Copy Markdown
Member

@ncooke3 ncooke3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want to test both backend and non-backend?

@cherylEnkidu
Copy link
Copy Markdown
Contributor Author

Do we want to test both backend and non-backend?

Yes, I am checking here to see whether the environment variable works. Ideally the test set should be like:

  1. TARGET_BACKEND = nightly BACKEND_EDITION = standard
  2. TARGET_BACKEND = nightly BACKEND_EDITION = enterprise
  3. TARGET_BACKEND = emulator BACKEND_EDITION = standard
  4. TARGET_BACKEND = emulator BACKEND_EDITION = enterprise

Comment thread .github/workflows/firestore.yml Outdated
Comment thread .github/workflows/firestore-nightly.yml Outdated
@cherylEnkidu cherylEnkidu changed the base branch from main to cheryl/changeNotIn January 14, 2026 21:37
Comment thread .github/workflows/sdk.firestore.yml
Comment thread .github/workflows/sdk.firestore.yml Outdated
@ncooke3 ncooke3 self-requested a review January 20, 2026 18:05
Base automatically changed from cheryl/changeNotIn to main January 26, 2026 21:06
@ncooke3 ncooke3 added the needs-jules-review Label for manually marking PRs as ready for a review from Jules. label Jan 28, 2026
Copy link
Copy Markdown

@laike9m laike9m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request introduces several improvements to Firestore CI and adds Enterprise integration tests. However, there are a few issues that need to be addressed, including a syntax error in scripts/build.sh that will break the CI, and a potential regression in pipeline behavior for Standard databases.

Comment thread scripts/build.sh Outdated
Comment thread scripts/build.sh Outdated
Comment thread Firestore/core/src/core/pipeline_util.cc Outdated
Comment thread Firestore/core/src/core/pipeline_util.cc Outdated
Comment thread Firestore/core/src/core/pipeline_util.cc
Copy link
Copy Markdown
Member

@ncooke3 ncooke3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!

Copy link
Copy Markdown
Contributor

@wu-hui wu-hui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have one question, otherwise looks good.

Comment thread Firestore/core/src/core/pipeline_util.cc
@cherylEnkidu cherylEnkidu merged commit beda7f4 into main Feb 5, 2026
165 of 167 checks passed
@cherylEnkidu cherylEnkidu deleted the cheryl/changeFirestoreCi branch February 5, 2026 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: firestore needs-jules-review Label for manually marking PRs as ready for a review from Jules.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants