Conversation
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. |
ncooke3
left a comment
There was a problem hiding this comment.
Do we want to test both backend and non-backend?
Yes, I am checking here to see whether the environment variable works. Ideally the test set should be like:
|
…on test as the new Swift tests introduced
laike9m
left a comment
There was a problem hiding this comment.
The pull request introduces several improvements to Firestore CI and adds Enterprise integration tests. However, there are a few issues that need to be addressed, including a syntax error in scripts/build.sh that will break the CI, and a potential regression in pipeline behavior for Standard databases.
wu-hui
left a comment
There was a problem hiding this comment.
I have one question, otherwise looks good.
#no-changelog
PR Title: Fix Firestore Enterprise CI hangs & Add Enterprise Integration Tests
Description
This PR addresses persistent timeouts in
FirestoreEnterprisejobs caused by resource exhaustion (OOM) on GitHub runners and expands Enterprise test coverage.Changes
xcodebuildconcurrency (-jobs 4) and split execution into separatebuild-for-testingandtest-without-buildingsteps. This prevents memory contention between the compiler and the Firestore Emulator.