Initialize Telemetry in Angular error handler constructor

[andrewbrook]

Discussion

Eagerly set up Telemetry in order to collect a "session started" event.

Testing

Manually

API Changes

N/A

[changeset-bot]

⚠️ No Changeset found

Latest commit: 72cec15

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[gemini-code-assist]

Summary of Changes

Hello @andrewbrook, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refactors the FirebaseErrorHandler to initialize the Telemetry service during its construction rather than on each error event. This eager initialization ensures that the Telemetry service is ready from the start, facilitating the capture of crucial early events like "session started" and potentially optimizing performance by avoiding redundant setup calls within the error handling logic.

Highlights

• Telemetry Initialization: The getTelemetry function call has been moved from the handleError method to the constructor of the FirebaseErrorHandler class.
• Eager Event Capture: This change ensures that Telemetry is initialized eagerly when the error handler is constructed, allowing for the collection of a "session started" event and avoiding repeated initialization on every error.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request refactors the FirebaseErrorHandler to initialize the Telemetry service in the constructor rather than within the handleError method. This is a good change as it aligns with the goal of eagerly starting a telemetry session and is also more efficient, as getTelemetry is now called only once per error handler instance. I have one suggestion to improve the code's encapsulation by not storing constructor parameters as class properties when they are only used during initialization.

[gemini-code-assist]

The constructor parameters app and telemetryOptions are only used within the constructor to initialize the telemetry property. They don't need to be stored as class properties. You can remove the private modifier from them and adjust the call to getTelemetry accordingly. This improves encapsulation by not exposing these properties on the class instance when they are not needed.

Suggested change

	private app: FirebaseApp,
	private telemetryOptions?: TelemetryOptions
	) {}
	) {
	this.telemetry = getTelemetry(this.app, this.telemetryOptions);
	app: FirebaseApp,
	telemetryOptions?: TelemetryOptions
	) {
	this.telemetry = getTelemetry(app, telemetryOptions);

[google-oss-bot]

Size Report ¹

Affected Products

No changes between base commit (518ad48) and merge commit (5750bb5).

Test Logs

• Base (518ad48): https://github.com/firebase/firebase-js-sdk/actions/runs/20049907818
• Merge (5750bb5): https://github.com/firebase/firebase-js-sdk/actions/runs/20078508832

1. https://storage.googleapis.com/firebase-sdk-metric-reports/bL7sR4O5H1.html

[google-oss-bot]

Size Analysis Report ¹

Affected Products

No changes between base commit (518ad48) and merge commit (5750bb5).

Test Logs

• Base (518ad48): https://github.com/firebase/firebase-js-sdk/actions/runs/20049907818
• Merge (5750bb5): https://github.com/firebase/firebase-js-sdk/actions/runs/20078508832

1. https://storage.googleapis.com/firebase-sdk-metric-reports/8IFirnaUCU.html