Collect Angular context when calling recordError directly #9433

andrewbrook · 2025-12-18T20:38:59Z

Discussion

Collect framework-specific attributes whenever recordError is called, explicitly or implicitly.

Testing

Unit tested, manually tested

API Changes

N/A

changeset-bot · 2025-12-18T20:39:04Z

⚠️ No Changeset found

Latest commit: e125f7a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

gemini-code-assist · 2025-12-18T20:39:15Z

Summary of Changes

Hello @andrewbrook, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly enhances the Crashlytics integration for Angular applications by implementing a standardized way to automatically collect and attach framework-specific context to error reports. By introducing a flexible provider mechanism, the system now ensures that valuable diagnostic information, such as the Angular route path, is consistently included with every error, thereby improving the clarity and actionability of crash logs for developers.

Highlights

Framework-Specific Attribute Collection: Introduced a mechanism to collect framework-specific attributes (like Angular route path) whenever recordError is called, whether explicitly or implicitly.
Angular Integration Update: The FirebaseErrorHandler in Angular now registers a frameworkAttributesProvider with the Crashlytics service to automatically capture the Angular route path for error reports.
Centralized Attribute Handling: The core recordError function in api.ts was updated to check for and utilize this new frameworkAttributesProvider to enrich error logs with relevant context.
Service Extension: The CrashlyticsService now includes a frameworkAttributesProvider property, allowing framework-specific implementations to supply additional context dynamically.
Enhanced Testing: Unit tests were updated and new tests were added to ensure the correct collection and reporting of framework attributes, including handling of dynamic routes.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	`/gemini review`	Performs a code review for the current pull request in its current state.
Pull Request Summary	`/gemini summary`	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	`/gemini help`	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist

Code Review

This pull request refactors the collection of Angular-specific context for error reporting by introducing a frameworkAttributesProvider on the CrashlyticsService. This allows the recordError function to automatically include framework context, like the Angular route, even when called directly. This is a solid architectural improvement that enhances modularity. The changes are well-tested. I have one suggestion in packages/crashlytics/src/api.ts to prevent mutation of user-provided arguments, which is a recommended practice for robust APIs.

packages/crashlytics/src/api.ts

google-oss-bot · 2025-12-18T20:58:33Z

Size Report ¹

Affected Products

@firebase/crashlytics
Type Base (e3691f6) Merge (5bb5c09) Diff
browser 9.71 kB 10.1 kB +420 B (+4.3%)
main 8.68 kB 9.10 kB +420 B (+4.8%)
module 9.71 kB 10.1 kB +420 B (+4.3%)
firebase
Type Base (e3691f6) Merge (5bb5c09) Diff
firebase-crashlytics.js 88.8 kB 89.0 kB +240 B (+0.3%)

Test Logs

https://storage.googleapis.com/firebase-sdk-metric-reports/A3sFyLWd6l.html

google-oss-bot · 2025-12-18T21:12:21Z

Size Analysis Report ¹

Affected Products

@firebase/crashlytics
- flush
  Size
  Type Base (e3691f6) Merge (5bb5c09) Diff
  size 5.21 kB 5.36 kB +146 B (+2.8%)
  size-with-ext-deps 64.6 kB 64.8 kB +146 B (+0.2%)
- getCrashlytics
  Size
  Type Base (e3691f6) Merge (5bb5c09) Diff
  size 5.38 kB 5.53 kB +146 B (+2.7%)
  size-with-ext-deps 71.7 kB 71.9 kB +146 B (+0.2%)
- nextOnRequestError
  Size
  Type Base (e3691f6) Merge (5bb5c09) Diff
  size 6.32 kB 6.56 kB +243 B (+3.8%)
  size-with-ext-deps 72.7 kB 72.9 kB +243 B (+0.3%)
- recordError
  Size
  Type Base (e3691f6) Merge (5bb5c09) Diff
  size 5.94 kB 6.19 kB +243 B (+4.1%)
  size-with-ext-deps 65.3 kB 65.6 kB +243 B (+0.4%)

Test Logs

https://storage.googleapis.com/firebase-sdk-metric-reports/JS7Q1ysVMd.html

Collect Angular context when calling recordError directly

4eb2708

gemini-code-assist bot reviewed Dec 18, 2025

View reviewed changes

packages/crashlytics/src/api.ts Outdated Show resolved Hide resolved

Update attribute priority

e125f7a

andrewbrook marked this pull request as ready for review December 18, 2025 20:50

andrewbrook requested a review from a team as a code owner December 18, 2025 20:50

andrewbrook requested review from hsubox76 and tonybaroneee December 18, 2025 20:50

andrewbrook removed request for hsubox76 and tonybaroneee December 18, 2025 21:16

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Collect Angular context when calling recordError directly #9433

Collect Angular context when calling recordError directly #9433

andrewbrook commented Dec 18, 2025

Uh oh!

changeset-bot bot commented Dec 18, 2025 •

edited

Loading

Uh oh!

gemini-code-assist bot commented Dec 18, 2025

Uh oh!

gemini-code-assist bot left a comment

Uh oh!

Uh oh!

google-oss-bot commented Dec 18, 2025 •

edited

Loading

`@firebase/crashlytics`

`firebase`

Uh oh!

google-oss-bot commented Dec 18, 2025 •

edited

Loading

`@firebase/crashlytics`

`flush`

`getCrashlytics`

`nextOnRequestError`

`recordError`

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Collect Angular context when calling recordError directly #9433

Are you sure you want to change the base?

Collect Angular context when calling recordError directly #9433

Conversation

andrewbrook commented Dec 18, 2025

Discussion

Testing

API Changes

Uh oh!

changeset-bot bot commented Dec 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

⚠️ No Changeset found

Uh oh!

gemini-code-assist bot commented Dec 18, 2025

Summary of Changes

Highlights

Footnotes

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

google-oss-bot commented Dec 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Size Report 1

Affected Products

@firebase/crashlytics

firebase

Test Logs

Uh oh!

google-oss-bot commented Dec 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Size Analysis Report 1

Affected Products

@firebase/crashlytics

flush

getCrashlytics

nextOnRequestError

recordError

Test Logs

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

changeset-bot bot commented Dec 18, 2025 •

edited

Loading

google-oss-bot commented Dec 18, 2025 •

edited

Loading

Size Report ¹

`@firebase/crashlytics`

`firebase`

google-oss-bot commented Dec 18, 2025 •

edited

Loading

Size Analysis Report ¹

`@firebase/crashlytics`

`flush`

`getCrashlytics`

`nextOnRequestError`

`recordError`