Skip to content

Conversation

@yesudeep
Copy link
Contributor

@yesudeep yesudeep commented Jan 8, 2026

zsh❯ py/bin/run_sample
Indexed 0 traces in 0ms in /Users/yesudeep/code/github.com/firebase/genkit/py/samples/model-garden/.genkit/traces_idx
Telemetry API running on http://localhost:4033
Project root: /Users/yesudeep/code/github.com/firebase/genkit/py/samples/model-garden
Genkit Developer UI: http://localhost:4000
Using CPython 3.12.8
Creating virtual environment at: /Users/yesudeep/code/github.com/firebase/genkit/py/.venv
Installed 38 packages in 50ms
2026-01-07 18:25:17 [debug    ] Creating a new global tracer provider for telemetry.
2026-01-07 18:25:17 [debug    ] local_telemetry_server exporter added succesfully.
Traceback (most recent call last):
  File "/Users/yesudeep/code/github.com/firebase/genkit/py/samples/model-garden/src/main.py", line 20, in <module>
    from genkit.plugins.vertex_ai.model_garden import VertexAIModelGarden, model_garden_name
ModuleNotFoundError: No module named 'genkit.plugins.vertex_ai'
/Users/yesudeep/.local/share/pnpm/global/5/.pnpm/@genkit-ai+tools-common@1.27.0_@types+node@22.13.5/node_modules/@genkit-ai/tools-common/lib/cjs/src/manager/process-manager.js:54
                    reject(new Error(`app process exited with code ${code}`));
                           ^

Error: app process exited with code 1
    at ChildProcess.<anonymous> (/Users/yesudeep/.local/share/pnpm/global/5/.pnpm/@genkit-ai+tools-common@1.27.0_@types+node@22.13.5/node_modules/@genkit-ai/tools-common/lib/cjs/src/manager/process-manager.js:54:28)
    at ChildProcess.emit (node:events:507:28)
    at ChildProcess._handle.onexit (node:internal/child_process:294:12)

Node.js v23.11.1

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @yesudeep, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses and resolves dependency issues within the Python project structure. It specifically ensures that the Vertex AI plugin and the Model Garden sample have their required genkit related dependencies correctly declared in their respective pyproject.toml files and subsequently locked in uv.lock. This fix prevents potential runtime errors or build failures stemming from missing packages.

Highlights

  • Vertex AI Plugin Dependencies: The py/plugins/vertex-ai/pyproject.toml file has been updated to include genkit-plugin-compat-oai as a new dependency, ensuring proper functionality for the Vertex AI plugin.
  • Model Garden Sample Dependencies: The py/samples/model-garden/pyproject.toml file now correctly lists genkit-plugin-vertex-ai as a dependency, resolving dependency issues for the Model Garden sample.
  • Dependency Lock File Update: The py/uv.lock file has been regenerated to reflect the addition of genkit-plugin-compat-oai for the Vertex AI plugin and genkit-plugin-vertex-ai for the Model Garden sample, ensuring consistent and reproducible builds.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request correctly updates dependencies for the model-garden sample and the vertex-ai plugin. The changes are necessary to ensure the sample works as expected. I have one suggestion to improve maintainability by sorting the dependencies alphabetically.

@yesudeep yesudeep marked this pull request as draft January 8, 2026 01:41
@yesudeep yesudeep marked this pull request as ready for review January 8, 2026 02:27
@yesudeep yesudeep enabled auto-merge (squash) January 8, 2026 02:27
@yesudeep yesudeep disabled auto-merge January 8, 2026 02:28
@yesudeep yesudeep enabled auto-merge (squash) January 8, 2026 02:28
@yesudeep yesudeep merged commit 034fe18 into main Jan 8, 2026
10 checks passed
@yesudeep yesudeep deleted the yesudeep/fix/snobbish-walk branch January 8, 2026 02:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants