-
Notifications
You must be signed in to change notification settings - Fork 632
feat(go): added support for sessions #4067
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Summary of ChangesHello @apascal07, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces a robust session management system for Genkit in Go. It provides a core, generic API for creating and managing stateful sessions, along with a flexible Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces a comprehensive session management feature, including a core API, an in-memory store, and a Firestore-backed persistent store. The overall design is solid, leveraging Go generics and the options pattern effectively. The accompanying tests are thorough. My review focuses on a couple of critical correctness issues: one related to ensuring deep copies for thread safety in the core Session object, and another concerning the correct handling of CreatedAt timestamps in the FirestoreSessionStore. I've also suggested improvements to the tests to better cover these edge cases.
This PR adds experimental session management APIs for Genkit Go, enabling stateful execution environments that persist across requests.
Summary
sessionpackage (core/x/session) - Core session management with typed stateplugins/firebase/x) - Persistent sessions backed by FirestoreCore Session API
Session Stores
In-Memory Store (for development/testing):
Firestore Store (for production):
Using Sessions with Tools
Tools can access and modify session state via context:
Checklist (if applicable):