Skip to content

Conversation

@hugoaguirre
Copy link
Contributor

@hugoaguirre hugoaguirre commented Jan 8, 2026

Checklist (if applicable):

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @hugoaguirre, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a new plugin for integrating OpenAI services into the Go Genkit framework. It establishes the necessary infrastructure to communicate with OpenAI's API, allowing Genkit applications to leverage OpenAI's large language models for chat and embedding functionalities. The plugin handles the complex mapping between Genkit's abstract AI interfaces and OpenAI's specific API request and response formats, including support for various message roles and tool interactions.

Highlights

  • OpenAI Go SDK Integration: The project now includes the github.com/openai/openai-go/v3 dependency, enabling interaction with OpenAI's latest API.
  • Core OpenAI Plugin Implementation: A new openai.go file introduces the OpenAI plugin struct, responsible for initializing the OpenAI client, defining models and embedders, and listing available OpenAI actions.
  • Genkit to OpenAI Message Conversion: Comprehensive logic is added to translate Genkit's ai.Message and ai.Part structures into OpenAI's ChatCompletionMessageParamUnion for system, model, user, and tool messages.
  • Tool Definition and Choice Handling: The plugin now supports converting Genkit's ai.ToolDefinition and ai.ToolChoice into OpenAI's corresponding tool parameters, including function definitions and tool call handling.
  • Embedder Functionality: An Embedder interface is implemented, allowing Genkit to use OpenAI's embedding models by converting ai.EmbedRequest to openai.EmbeddingNewParams.
  • Model Capabilities Extension: The go/plugins/internal/models.go file is updated to include a Media ModelSupports constant, indicating support for models handling both media and text.
  • Unit Tests for Message Conversion: New unit tests in openai_test.go validate the correctness of the message and tool conversion functions, ensuring proper mapping between Genkit and OpenAI message formats.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a new OpenAI plugin for Go. The initial scaffolding is in place, including the plugin structure, dependency updates, and type conversion functions for requests. However, the core functionality for model generation is largely incomplete. Several key functions like DefineModel, generateStream, and generateComplete are stubbed out and return errors or nil. I've left specific comments on these areas that need to be implemented for the plugin to be functional. I've also pointed out a few other areas for improvement regarding configuration handling, logging, and security.

Comment on lines +81 to +89
apiKey := os.Getenv("OPENAI_API_KEY")
if apiKey != "" {
o.Opts = append([]option.RequestOption{option.WithAPIKey(apiKey)}, o.Opts...)
}

baseURL := os.Getenv("OPENAI_BASE_URL")
if baseURL != "" {
o.Opts = append([]option.RequestOption{option.WithBaseURL(baseURL)}, o.Opts...)
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The APIKey and BaseURL fields on the OpenAI struct are not used during initialization. The Init function only reads credentials from environment variables. To allow programmatic configuration, the Init function should also consider these fields, with a clear precedence order (e.g., struct fields overriding environment variables).

Suggested change
apiKey := os.Getenv("OPENAI_API_KEY")
if apiKey != "" {
o.Opts = append([]option.RequestOption{option.WithAPIKey(apiKey)}, o.Opts...)
}
baseURL := os.Getenv("OPENAI_BASE_URL")
if baseURL != "" {
o.Opts = append([]option.RequestOption{option.WithBaseURL(baseURL)}, o.Opts...)
}
apiKey := o.APIKey
if apiKey == "" {
apiKey = os.Getenv("OPENAI_API_KEY")
}
if apiKey != "" {
o.Opts = append([]option.RequestOption{option.WithAPIKey(apiKey)}, o.Opts...)
}
baseURL := o.BaseURL
if baseURL == "" {
baseURL = os.Getenv("OPENAI_BASE_URL")
}
if baseURL != "" {
o.Opts = append([]option.RequestOption{option.WithBaseURL(baseURL)}, o.Opts...)
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

Status: No status

Development

Successfully merging this pull request may close these issues.

1 participant