Open
Conversation
|
|
cosmpop
approved these changes
Mar 10, 2025
| @@ -0,0 +1,35 @@ | |||
| <head> | |||
There was a problem hiding this comment.
@nanimal-fb I don't think you need this. It will use the implementation done in the parent theme https://github.com/firebolt-db/just-the-docs/blob/37ab11309cc2c896b27a806114287d165f7c6a85/_includes/head.html#L28C14-L28C25
I don't think it will break anything and you may also keep this here
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.




HI Cosmin - I tried to implement google tag manager on these docs based on what you did in 2.0 but I know it's not going to work because the docs structure is different. Can you help me fix it please?