build(FIR-38687): Relax anyio version requirements#456
Merged
Conversation
|
bogdantruta-firebolt
approved these changes
Sep 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #455
Newer version of anyio breaks our unit tests. Turns out it's due to us using a private method of a lock that has changed since.
While we still can hack around and access the "original" class I have a feeling that it can be refactored soon so it's safer to keep relying on the anyio Lock interface.
In this particular case, when we end up in a situation where we try to unlock not our own lock, we can catch the error raised. However, the error class is very generic - RuntimeError, so we have to also check the error message to some extent.