Skip to content

test(FIR-49477): Fix error check for SA with no user #458

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ptiurin merged 1 commit into from
Oct 2, 2025
Merged

test(FIR-49477): Fix error check for SA with no user #458

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions tests/integration/dbapi/async/V2/test_errors_async.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ async def test_account_no_user(
"""Connection properly reacts to account that doesn't have
a user attached to it."""

with raises(AccountNotFoundOrNoAccessError) as exc_info:
with raises((AccountNotFoundOrNoAccessError, FireboltStructuredError)) as exc_info:
async with await connect(
database=database_name,
auth=auth_no_user,
Expand All @@ -50,8 +50,12 @@ async def test_account_no_user(
) as connection:
await connection.cursor().execute("show tables")

assert f"'{account_name}' does not exist" in str(
exc_info.value
assert str(exc_info.value).startswith(
f"Account '{account_name}' does not exist"
) or (
# Caching on the backend may cause this error instead
f"Database '{database_name}' does not exist or not authorized."
in str(exc_info.value)
), "Invalid account error message."


Expand Down
6 changes: 5 additions & 1 deletion tests/integration/dbapi/sync/V2/test_errors.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ def test_account_no_user(
api_endpoint: str,
) -> None:
"""Connection properly reacts to invalid account error."""
with raises(AccountNotFoundOrNoAccessError) as exc_info:
with raises((AccountNotFoundOrNoAccessError, FireboltStructuredError)) as exc_info:
with connect(
database=database_name,
auth=auth_no_user,
Expand All @@ -50,6 +50,10 @@ def test_account_no_user(

assert str(exc_info.value).startswith(
f"Account '{account_name}' does not exist"
) or (
# Caching on the backend may cause this error instead
f"Database '{database_name}' does not exist or not authorized."
in str(exc_info.value)
), "Invalid account error message."


Expand Down
Loading