Conversation
Co-Authored-By: petro.tiurin@firebolt.io <petro.tiurin@firebolt.io>
Contributor
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
|
ptiurin
approved these changes
Oct 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



chore(NoTicket): remove enable_create_table_with_struct_type setting
Summary
Removed the
SET enable_create_table_with_struct_type=true;statement from thesetup_struct_querytest fixture intests/integration/dbapi/conftest.py. According to the requester, this setting is no longer needed and the CREATE TABLE statements with struct types work correctly without it.Review & Testing Checklist for Human
setup_struct_queryfixture used by struct-related tests. Ensure all tests using this fixture still pass in CI.Notes
Devin run: https://app.devin.ai/sessions/347340519e744009b0f0ee6746ef57eb
Requested by: petro.tiurin@firebolt.io (@ptiurin)