Merged
Conversation
|
bogdantruta-firebolt
approved these changes
Nov 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



This pull request addresses a bug in the Firebolt engine caching logic that previously caused incorrect database context to be used when switching databases with the same engine. The main fix ensures that the
databaseparameter is not cached with engine information, preventing database context from being overwritten when reusing engine cache entries. The changes also add comprehensive integration and unit tests to verify correct behavior for both async and sync connections, and update test factories for better flexibility.Bug Fixes and Engine Caching Improvements:
use_engineanduse_engine_asyncmethods to exclude thedatabaseparameter from engine cache entries, ensuring that switching databases with the same engine does not overwrite the database context. [1] [2]Testing Enhancements:
databaseparameter. [1] [2] [3]databaseparameter, improving test flexibility and coverage. [1] [2]