Conversation
|
goprean
approved these changes
Nov 17, 2025
Collaborator
goprean
left a comment
goprean
left a comment
There was a problem hiding this comment.
Do we have tests for sql alchemy? Should we add a test as well?
bogdantruta-firebolt
approved these changes
Nov 17, 2025
Contributor
Author
Will be added as a separate PR - there are some unrelated issues with the tests. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Starting from
sqlalchemy==2.0.44it uses _async_soft_close to safely close the cursor behind the scenes.Since we create our own wrappers we don't have this method and fail on such call. Adding a stub for it to avoid failures.
For a long-term solution we should migrate to AsyncIODBAPICursor. This will be done as a separate PR since it requires more changes and testing.
Closes #113