Prevent using get_me with input

[orsinium]

1. Make get_me return a new Me type instead of Peer.
2. This type can be used only with get_settings or for equality comparison with Peer.

While you can, if you really want, convert Me to Peer by iterating over Peers and picking the one that equals to Me (or going through into_u8 -> from_u8), it would require deliberately going out of your way to shoot yourself in the foot. So, the change should prevent the most common pitfalls, like read_pad(get_me()).

See firefly-zero/firefly-runtime#9.

[oli-obk]

Yea this'll prevent most issues. I'm still curious where one would need comparisons between Peer and Me outside of render, but that likely just means checking the catalog games' sources and chatting with the authors

[orsinium]

I'm still curious where one would need comparisons between Peer and Me outside of render

Probably nowhere. I just don't see an easy way to enforce "you can compare these two types but only when called from render". I could use a marker passed from render for it (or just pass Me into render, as you suggested initially) but that's too messy.

[oli-obk]

Yea considering this is usually a trivially noticeable bug in multiplayer and has lots of docs pointing ppl away from making such bugs, I don't think any "security" level kinds of protection are necessary