Skip to content

[BHP1-1573] Fix Table Shader Rounding#230

Open
Kcheung42 wants to merge 1 commit into
mainfrom
kc-BHP1-1573-fix-table-shader-rounding
Open

[BHP1-1573] Fix Table Shader Rounding#230
Kcheung42 wants to merge 1 commit into
mainfrom
kc-BHP1-1573-fix-table-shader-rounding

Conversation

@Kcheung42
Copy link
Copy Markdown
Collaborator

@Kcheung42 Kcheung42 commented May 13, 2026


Purpose

  • Table Shaders were incorrectly shading cells because there is a mismatched on what is displayed (rounded value based on precision) vs using un-rounded values in the shading logic. To fix this we need to ensure table shading filters round all values in the logic to the same precision as what is displayed.

Related Issues

Closes BHP1-1573

Submission Checklist

  • Included Jira issue in the PR title (e.g. BHP1-### <title>)
  • Code passes linter rules (clj-kondo --lint components/**/src bases/**/src projects/**/src)
  • Feature(s) work when compiled (clojure -M:compile-cljs)

Testing

  1. open this worksheet: BHP1-1573.zip
  2. In settings, change the decimal precision for Surface Rate of Spread to 1
  3. Navigate to settings page, take note of the table filter setting. should be 0.2 -> 26
  4. Navigate to results and ensure that cells are properly shaded
  5. One cell that was not properly shaded previously was:

Backing Rate of Spread (ch/h)

  • Fuel Model Code: GR1/101
  • Live Herbaceous Fuel Moisture: 120%

The true value of the cell was actually 0.19342908711679715. The old logic did not round this number and flagged it for shading, but what is displayed is 0.2 on the results, so this causes confusion.

Screenshots

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant