api: throw error in addIceCandidate when peer connection is closed#14
Open
MiloszFilimowski wants to merge 1 commit intofishjam-cloud:masterfrom
Open
api: throw error in addIceCandidate when peer connection is closed#14MiloszFilimowski wants to merge 1 commit intofishjam-cloud:masterfrom
MiloszFilimowski wants to merge 1 commit intofishjam-cloud:masterfrom
Conversation
Browsers (Chrome, Firefox, Safari) throw an InvalidStateError when addIceCandidate is called on a closed RTCPeerConnection, as per the W3C WebRTC spec. This change aligns react-native-webrtc with that behavior by throwing an error instead of silently proceeding. This is consistent with how addTrack and removeTrack already handle the closed state in this codebase. Fixes: #1795
There was a problem hiding this comment.
Pull request overview
This PR aligns react-native-webrtc's addIceCandidate behavior with the W3C WebRTC spec and with browser implementations (Chrome, Firefox, Safari) by throwing an error when the method is called on a closed RTCPeerConnection, instead of silently proceeding into native module calls.
Changes:
- Adds a closed-state guard at the start of
addIceCandidate, throwingnew Error('Peer Connection is closed')— matching the identical check already used byaddTrackandremoveTrack.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Browsers (Chrome, Firefox, Safari) throw an InvalidStateError when addIceCandidate is called on a closed RTCPeerConnection, as per the W3C WebRTC spec. This change aligns react-native-webrtc with that behavior by throwing an error instead of silently proceeding.
This is consistent with how addTrack and removeTrack already handle the closed state in this codebase.
Fixes: react-native-webrtc#1795