-
Notifications
You must be signed in to change notification settings - Fork 5
FCE-2382: Fix appintentsmetadataprocessor with screen sharing target #526
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,41 @@ | ||
| require 'json' | ||
|
|
||
| package = JSON.parse(File.read(File.join(__dir__, 'package.json'))) | ||
| base_content = File.read(File.join(__dir__, 'FishjamCloudClient.podspec')) | ||
|
|
||
| base_config = { | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Btw, is there no other option to just get those values from a different podspec?
Collaborator
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I haven't found any other way. Do you know of any? The other idea that I had was to store the common values in JSON and then fetch it in both files, but I decided this is simpler. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. If there is no simple import then this seems enough. I have no knowledge of other options unfortunately :/ |
||
| homepage: base_content[/s\.homepage\s*=\s*['"]([^'"]+)['"]/, 1], | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Seems like the big part of the regex is repeating, maybe move it to variable? |
||
| license_type: base_content[/s\.license\s*=\s*\{[^}]*:type\s*=>\s*['"]([^'"]+)['"]/, 1], | ||
| license_file: base_content[/s\.license\s*=\s*\{[^}]*:file\s*=>\s*['"]([^'"]+)['"]/, 1], | ||
| author_name: base_content[/s\.author\s*=\s*\{\s*['"]([^'"]+)['"]/, 1], | ||
| author_url: base_content[/s\.author\s*=\s*\{[^}]*['"][^'"]*['"]\s*=>\s*['"]([^'"]+)['"]/, 1], | ||
| deployment_target: base_content[/s\.ios\.deployment_target\s*=\s*['"]([^'"]+)['"]/, 1], | ||
| swift_version: base_content[/s\.swift_version\s*=\s*['"]([^'"]+)['"]/, 1], | ||
| resources: base_content[/s\.resources\s*=\s*['"]([^'"]+)['"]/, 1], | ||
| xcconfig_key: base_content[/s\.pod_target_xcconfig\s*=\s*\{\s*['"]([^'"]+)['"]/, 1], | ||
| xcconfig_value: base_content[/s\.pod_target_xcconfig\s*=\s*\{[^}]*['"][^'"]*['"]\s*=>\s*['"]([^'"]+)['"]/, 1], | ||
| webrtc_version: base_content[/s\.dependency\s+['"]WebRTC-SDK['"]\s*,\s*['"]([^'"]+)['"]/, 1], | ||
| swift_protobuf_version: base_content[/s\.dependency\s+['"]SwiftProtobuf['"]\s*,\s*['"]([^'"]+)['"]/, 1] | ||
| } | ||
|
|
||
| Pod::Spec.new do |s| | ||
| s.name = 'FishjamCloudBroadcastClient' | ||
| s.version = package['version'] | ||
| s.summary = 'Fishjam Broadcast Extension SDK for iOS screen sharing and broadcast functionality.' | ||
|
|
||
| s.homepage = base_config[:homepage] | ||
| s.license = { :type => base_config[:license_type], :file => base_config[:license_file] } | ||
| s.author = { base_config[:author_name] => base_config[:author_url] } | ||
| s.source = { :git => base_config[:homepage] + '.git', :tag => s.version.to_s } | ||
|
|
||
| s.ios.deployment_target = base_config[:deployment_target] | ||
| s.swift_version = base_config[:swift_version] | ||
|
|
||
MiloszFilimowski marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| s.source_files = "packages/ios-client/Sources/FishjamClient/media/BroadcastSampleSource.swift", "packages/ios-client/Sources/FishjamClient/ipc/**/*.{h,m,mm,swift}" | ||
| s.resources = base_config[:resources] | ||
|
|
||
| s.pod_target_xcconfig = { base_config[:xcconfig_key] => base_config[:xcconfig_value] } | ||
|
|
||
| s.dependency 'WebRTC-SDK', base_config[:webrtc_version] | ||
| s.dependency 'SwiftProtobuf', base_config[:swift_protobuf_version] | ||
| end | ||
MiloszFilimowski marked this conversation as resolved.
Show resolved
Hide resolved
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. newline |
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -6,7 +6,7 @@ | |
| "build": { | ||
| "base": { | ||
| "ios": { | ||
| "image": "macos-sequoia-15.3-xcode-16.2" | ||
| "image": "latest" | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Maybe better to have it set manually, no strong opinion on that though.
Collaborator
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This is intentional; we use this app to test our SDK, so if something breaks (like in this case), we want to know as soon as possible. It used to be like this until the above bug occurred, which forced us to lock the image version. |
||
| } | ||
| }, | ||
| "development": { | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,4 @@ | ||
| import FishjamCloudClient | ||
| import FishjamCloudBroadcastClient | ||
| import Foundation | ||
| import ReplayKit | ||
| import WebRTC | ||
|
|
||
Uh oh!
There was an error while loading. Please reload this page.