Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adjusts RTCView mirroring behavior in the mobile example to avoid flipped video in livestream viewing and to make room tiles mirror behavior depend on the type of track being displayed.
Changes:
- Set livestream viewer RTCView mirroring to always be disabled.
- Update room grid RTCView mirroring to depend on whether the track is a camera track vs screen share.
- Minor formatting/import ordering and trailing comma adjustments.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| examples/mobile-client/fishjam-chat/components/VideosGrid.tsx | Changes RTCView mirroring logic for grid tiles based on track type. |
| examples/mobile-client/fishjam-chat/app/livestream/viewer.tsx | Disables mirroring for viewer RTCView; includes an added debug log. |
| examples/mobile-client/fishjam-chat/app/livestream/screen-sharing.tsx | Import reordering + minor formatting (trailing comma). |
| examples/mobile-client/fishjam-chat/app/(tabs)/livestream.tsx | Import reordering only. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Changed mirroring effect on livestream to always be false and in rooms to be dynamic depending on whether we do screenshare or share our camera view
Motivation and Context
It was weird looking lol
Documentation impact
Types of changes
not work as expected)