client: remove HTTPClient interface
#2
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this interface was used to fullfill testing purposes by mocking `Do` method. Test logic has been changed to mock the transport with mocked RoundTrip. Signed-off-by: Mathieu Tortuyaux <mtortuyaux@microsoft.com>
it allows a more granular precision to mock tests rather than directly mocking the `Do` method. Signed-off-by: Mathieu Tortuyaux <mtortuyaux@microsoft.com>
invidian
reviewed
Oct 27, 2021
| }, | ||
| } { | ||
| h := &httpClient{ | ||
| h := http.DefaultClient |
Member
There was a problem hiding this comment.
DefaultClient is just &Client{}, so you can just initialize everything at one go as http.Client{Transport: ...}.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR, we remove the
HTTPClientinterface which was primary used for testing purposes. This comment: #1 (comment) made me discovered a better way to implement deeper mocking in the HTTP request.By mocking transport, we can chain them (like with Basic Auth transport) and have a better control on the expected i/o of the round tripper.
Tests do not change a lot, we just mock the round tripper instead of the
Domethod .