Conversation
So people can use latest Sioyek until there's a new release.
|
Started test build 112855 |
|
Build 112855 failed |
|
Started test build 112856 |
|
Build 112856 failed |
|
Started test build 112857 |
|
Build 112857 failed |
|
Started test build 112862 |
|
Build 112862 failed |
|
Started test build 112863 |
|
Build 112863 failed |
|
Started test build 112867 |
|
Build 112867 failed |
|
Started test build 112875 |
|
Build 112875 failed |
|
Started test build 112889 |
|
Build 112889 failed |
|
Started test build 112925 |
|
Build 112925 failed |
|
Your Qt module is great, and is being used in Lutris flatpak currently. But I believe it's not worth the maintainance burden to you and visual issues for users, to stick to the freedesktop runtime for sioyek. This being a Qt app, and this being a flatpak, indicates that user generally wouldn't mind Kde runtimes being pulled in. This should be reason enough for this app to pull in org.kde.platform. The user would not need to install it if they have another Qt app installed in past/future. What's your opinion @nbenitez ? |
|
My original intention is to have it depending on FreeDesktop runtime, that's why I got the trouble of building Qt in the first place, nonetheless I'll revisit this decision when a new Sioyek release arrives, especially if my Freedesktop version cannot build with latest updated deps (latest Qt5 or Qt6, etc.). Sioyek has GNOME and KDE users, and I think it's a plus for users we don't pull a full desktop runtime. I'm a GNOME user and I also hate when simple GTK apps pull GNOME runtime when a Freedesktop would be enough. |
|
BTW here's the data of the no of users with the 23.04 runtime specifically from GNOME users poll I made - especially those who visit the subreddit.. 35 have the runtime already I think the GNOME subreddit user would care more about the ui framework while selecting apps. So I feel much more than half GNOME users have the runtime from some other qt app. PS: I'm trying to nudge you in favour of using kde runtime. No offence intended :) |
|
Is this PR still relevant? |
Possible fix for issue #19