Skip to content

Testing possible fix for gnome theming issue#20

Open
nbenitez wants to merge 2 commits intobetafrom
fix_issue_19
Open

Testing possible fix for gnome theming issue#20
nbenitez wants to merge 2 commits intobetafrom
fix_issue_19

Conversation

@nbenitez
Copy link
Collaborator

@nbenitez nbenitez commented Apr 7, 2024

Possible fix for issue #19

So people can use latest Sioyek until there's a new release.
@flathubbot
Copy link

Started test build 112855

@flathubbot
Copy link

Build 112855 failed

@flathubbot
Copy link

Started test build 112856

@flathubbot
Copy link

Build 112856 failed

@flathubbot
Copy link

Started test build 112857

@nbenitez nbenitez mentioned this pull request Apr 7, 2024
@flathubbot
Copy link

Build 112857 failed

@flathubbot
Copy link

Started test build 112862

@flathubbot
Copy link

Build 112862 failed

@flathubbot
Copy link

Started test build 112863

@flathubbot
Copy link

Build 112863 failed

@flathubbot
Copy link

Started test build 112867

@flathubbot
Copy link

Build 112867 failed

@flathubbot
Copy link

Started test build 112875

@flathubbot
Copy link

Build 112875 failed

@flathubbot
Copy link

Started test build 112889

@flathubbot
Copy link

Build 112889 failed

@flathubbot
Copy link

Started test build 112925

@flathubbot
Copy link

Build 112925 failed

@Aman9das
Copy link

Aman9das commented Apr 7, 2024

Your Qt module is great, and is being used in Lutris flatpak currently.

But I believe it's not worth the maintainance burden to you and visual issues for users, to stick to the freedesktop runtime for sioyek.
KDE users also would have the app not integrate with the system, which isn't fair to them.

This being a Qt app, and this being a flatpak, indicates that user generally wouldn't mind Kde runtimes being pulled in. This should be reason enough for this app to pull in org.kde.platform. The user would not need to install it if they have another Qt app installed in past/future.

What's your opinion @nbenitez ?

@nbenitez
Copy link
Collaborator Author

nbenitez commented Apr 8, 2024

My original intention is to have it depending on FreeDesktop runtime, that's why I got the trouble of building Qt in the first place, nonetheless I'll revisit this decision when a new Sioyek release arrives, especially if my Freedesktop version cannot build with latest updated deps (latest Qt5 or Qt6, etc.).

Sioyek has GNOME and KDE users, and I think it's a plus for users we don't pull a full desktop runtime. I'm a GNOME user and I also hate when simple GTK apps pull GNOME runtime when a Freedesktop would be enough.

@Aman9das
Copy link

BTW here's the data of the no of users with the 23.04 runtime specifically from GNOME users poll I made - especially those who visit the subreddit..

https://www.reddit.com/r/gnome/comments/1bydiqp/survey_regarding_usage_of_qt_flatpak_apps_amongst/?utm_source=share&utm_medium=mweb3x&utm_name=mweb3xcss&utm_term=1&utm_content=share_button

35 have the runtime already
29 do not have it

I think the GNOME subreddit user would care more about the ui framework while selecting apps. So I feel much more than half GNOME users have the runtime from some other qt app.

PS: I'm trying to nudge you in favour of using kde runtime. No offence intended :)

@yakushabb
Copy link
Member

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants