gradle: Don't include missing resource URLs#520
Open
Newbytee wants to merge 1 commit intoflatpak:masterfrom
Open
gradle: Don't include missing resource URLs#520Newbytee wants to merge 1 commit intoflatpak:masterfrom
Newbytee wants to merge 1 commit intoflatpak:masterfrom
Conversation
If a given URL cannot be downloaded, Gradle will report it as the resource being missing. Respect this when finding URLs so we don't end up with URLs that are 404s. Also make the URL list a set to facilitate this. It doesn't need to contain duplicates anyway. Signed-off-by: Stefan Hansson <newbyte@postmarketos.org>
Newbytee
force-pushed
the
gradle-unavailable
branch
from
89f942c to
3185499
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If a given URL cannot be downloaded, Gradle will report it as the resource being missing. Respect this when finding URLs so we don't end up with URLs that are 404s.
Also make the URL list a set to facilitate this. It doesn't need to contain duplicates anyway.