-
Notifications
You must be signed in to change notification settings - Fork 9
[FXC-5449] allow varying refinements on axisymmetric body faces #1882
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
alexxu-flex
wants to merge
19
commits into
main
Choose a base branch
from
alexxu/varying-refinement-faces
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
7ddd2f7
first version
alexxu-flex bdc0285
Merge branch 'main' of github.com:flexcompute/Flow360 into alexxu/var…
alexxu-flex d62042e
Merge branch 'main' of github.com:flexcompute/Flow360 into alexxu/var…
alexxu-flex 6dbf834
Merge branch 'main' of github.com:flexcompute/Flow360 into alexxu/var…
alexxu-flex 69c56f8
black
alexxu-flex c7fc526
bugfix: unit conversion in dicts
alexxu-flex 55c50bd
resolve merge conflict; improve test location
alexxu-flex f77647f
cursor comment: unify recursive preprocess dimension
alexxu-flex c04f7d6
add Face class, switch API to axisymm_body.face(n)
alexxu-flex bdc9aaf
Merge branch 'main' of github.com:flexcompute/Flow360 into alexxu/var…
alexxu-flex 8e45cfc
add face class standalone unit test
alexxu-flex 359b8e1
use entity name for face_spacing to align with C++ parser
alexxu-flex b19cd53
Merge branch 'main' of github.com:flexcompute/Flow360 into alexxu/var…
alexxu-flex 200f6b4
Merge branch 'main' into alexxu/varying-refinement-faces
benflexcompute b1021ec
Merge branch 'main' of github.com:flexcompute/Flow360 into alexxu/var…
alexxu-flex ecd9921
refactor face_spacing to dict[segment, length], cleaner validation
alexxu-flex a6336cb
Merge branch 'main' of github.com:flexcompute/Flow360 into alexxu/var…
alexxu-flex ffce319
Merge branch 'alexxu/varying-refinement-faces' of github.com:flexcomp…
alexxu-flex 4b64c60
cursor feedback: check face_spacing entities against entity list, w/ …
alexxu-flex File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is too nested and confusing. We need to redesign the interface.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
//User interface
face_spacing={
axisymmetric_body.segments[1] : 0.2*fl.u.cm
}
// Storage side
"face_spacing":{
("entioty_id":"$axisymmetric_body.private_attribute_id", "segment_index": 1) : {"value": 0.2, "units":"cm"}
}
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Then you need a Pydantic model for the "segment" class.
It will be similar relationship between Windtunnel farfield and the windtunnel ghost surfaces.