Conversation
|
@thomascfd this looks really nice, thanks for the great work. I worked through the Wall_Model example in detail: reviewed code, formatted, and committed some changes. I think these edits are likely to be applicable to the other examples as well. Please take a look at the commit differences and see what makes sense to forward to the other examples. Some additional recommendations: |
examples/Solver_Features/Debug_Divergence/Print_Divergence_Locations.py
Outdated
Show resolved
Hide resolved
examples/Solver_Features/Debug_Divergence/Print_Divergence_Locations.py
Outdated
Show resolved
Hide resolved
examples/Solver_Features/Debug_Divergence/Print_Divergence_Locations.py
Outdated
Show resolved
Hide resolved
…s' into thomas/Customer_Outreach_Examples
This PR contains scripts for the customer outreach examples updated based on recent Flow360Scripts guidelines.
Options for case submission are both from Mesh ID (added to examples in admin portal, but not visible in new python client. To use this, log-in to examples account directly) and upload from S3 (currently many meshes are not uploaded yet so "PLACEHOLDER" put in place of URL. Meshes can also be taken from the google drive folder https://drive.google.com/drive/folders/1cmuOoGXwFsOaUbI1oKaKhWpDJ-8DaxAf and ran with the submit_cases_from_downloads.py scripts.
XV15 adaptive CFL contains two JSON files as "volume zones" still doesn't work in new python client. We will remove legacy json once it does.
Some pylint issues still exist due to capitalization or recent .format change in print_divergence_locations.py.