feat(sound): integrates sound tests and fixes Web Audio errors #265
+1,384
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Integrates and refactors sound tests from https://github.com/commercetest/babylonjs-sound-testing repo which were created as for this purpose.
Adds comprehensive test coverage (59 tests) with audio utilities, integration tests, verification tests, and diagnostics. Note: there are still more tests available in the babylonjs-sound-testing repo that may be relevant. This commit is already large so I'd prefer to consider them once this work has been reviewed and merged.
Details:
Test Suite Changes:
Bug Fixes:
Test Organization:
Results: 59/59 tests passing, no Web Audio errors
Related to issue #264
documenting
playSound()promise behavior andplayNotes()array handling.