feat: add configuration cache compatibility#4
Open
ffluk3 wants to merge 1 commit into
Open
Conversation
The plugin previously called task.notCompatibleWithConfigurationCache() on every AMD task, explicitly opting out of Gradle's configuration cache. This change removes that opt-out and fixes the underlying incompatibilities that made it necessary. What was fixed: - configureTaskGuard() now captures only the project path (String) and the AffectedModuleDetectorWrapper extension; no Task/Project in the lambda - withPlugin() delegates to configureTaskGuard() instead of baking an eager boolean - DependencyTracker eagerly computes its dependency map at construction so no Project reference is retained in a serialized field - All build service and ValueSource parameters converted to Property<T>, RegularFileProperty, and ListProperty<T> - Log file creation and git root discovery moved into the AffectedModuleDetectorLoader service init (runs at execution time, not configuration time) - disableConfigCache() and all callsites removed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The plugin previously called task.notCompatibleWithConfigurationCache() on every AMD task, explicitly opting out of Gradle's configuration cache. This change removes that opt-out and fixes the underlying incompatibilities that made it necessary.
What was fixed: