Merged
Conversation
Signed-off-by: drew <me@andrinoff.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Skip IMAP IDLE for accounts that don't have the selected folder, and make IDLE stop/restart non-blocking so it doesn't freeze the UI.
Why?
When switching to a folder that only some accounts have, IDLE was started for every account — causing repeated "no such mailbox" errors for accounts missing that folder. Additionally, all IDLE stop/restart operations blocked on the UI goroutine waiting for IMAP connections to gracefully close, which takes seconds per connection and froze the app on folder switches and quit.