Improve bookmark rename/delete on bufferlo bookmarks#77
Open
shipmints wants to merge 1 commit intoflorommel:mainfrom
Open
Improve bookmark rename/delete on bufferlo bookmarks#77shipmints wants to merge 1 commit intoflorommel:mainfrom
shipmints wants to merge 1 commit intoflorommel:mainfrom
Conversation
See florommel#70 * bufferlo.el (bufferlo--active-set-name-for-bookmark): Rename to 'bufferlo--active-set-names-for-bookmark'. (bufferlo--active-set-names-for-bookmark): Rename from 'bufferlo--active-set-name-for-bookmark' and return a list of active set names rather than just one. (bufferlo-mode-line-format): Change to call 'bufferlo--active-set-names-for-bookmark'. (bufferlo-bookmark-rename-confirmations): New user option. (bufferlo-bookmark-delete-confirmations): New user option. (bufferlo--bookmark-handlers): Change defvar to defconst. (bufferlo--bookmark-handler-types): New defconst. (bufferlo-mode): Install/remove bufferlo--bookmark-delete-all-advice. (bufferlo--bookmark-type): New function. (bufferlo--rename-tab-bookmark): New function. (bufferlo--rename-frame-bookmark): New function. (bufferlo--rename-or-delete-bookmark-in-sets): New function. (bufferlo--rename-bookmark): New function. (bufferlo--bookmark-rename-advice) (bufferlo--bookmark-delete-advice): Change to prompt under various destructive conditions. (bufferlo--bookmark-delete-all-advice): New function. * README.org (General bookmark commands): Document new features. (Complete configuration sample): Document new user options.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #70
(bufferlo--active-set-names-for-bookmark): Rename from 'bufferlo--active-set-name-for-bookmark' and return a list of active set names rather than just one.
(bufferlo-mode-line-format): Change to call
'bufferlo--active-set-names-for-bookmark'.
(bufferlo-bookmark-rename-confirmations): New user option. (bufferlo-bookmark-delete-confirmations): New user option. (bufferlo--bookmark-handlers): Change defvar to defconst. (bufferlo--bookmark-handler-types): New defconst.
(bufferlo-mode): Install/remove
bufferlo--bookmark-delete-all-advice.
(bufferlo--bookmark-type): New function.
(bufferlo--rename-tab-bookmark): New function.
(bufferlo--rename-frame-bookmark): New function.
(bufferlo--rename-or-delete-bookmark-in-sets): New function. (bufferlo--rename-bookmark): New function.
(bufferlo--bookmark-rename-advice)
(bufferlo--bookmark-delete-advice): Change to prompt under various destructive conditions.
(bufferlo--bookmark-delete-all-advice): New function.