-
Notifications
You must be signed in to change notification settings - Fork 41
Martin pull request (Added nginx server for reverse proxy) #14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
…r for the generate-proxy error
|
👀 We've notified the reward creators here. |
|
/claim #7 |
|
🤝 You already claimed this issue, you don't have to do it again! |
|
Hi @TintinSDev Thank you for your contribution. Before merging the pull request, could you please update the README.md file with a description of the changes made? Also, I noticed that a venv directory was created for dependencies. Could you instead list the dependencies in a requirements.txt file? This will make it easier for others to install the required packages. Thanks in advance! Best regards, |
|
Why was an entire python venv committed? This is not the way. I am also questioning the need for nginx but haven't inspected that part yet. Will take a look. |
I'll be removing the venv dir |
Hello @flowese |
|
Hi @TintinSDev I have reviewed the changes and noticed that you have updated the README, which is great, thank you for that! However, I have a few questions: Could you explain a bit more about the need to implement a reverse proxy with Nginx? I would like to better understand the purpose and benefits this brings to the project. As @bitnom mentioned, the implementation of Nginx doesn't seem justified and complicates the use of this wrapper, as users would need to provision and configure Nginx. TwoCaptcha is a paid service, and since this wrapper is open source and free, is there any option for users to solve captchas manually without relying on a third-party service? This could be useful for those who prefer not to incur additional costs. Perhaps we could offer an option for users to solve captchas manually or integrate another method that doesn't involve additional costs for users. Thanks in advance for the clarification! Best regards, |
|
Hi @TintinSDev, any updates on this? Would be highly appreciated! |
/claim #7