Skip to content

os: dirent: Avoid to use PathIsDirectoryA and SHCreateDirectoryEx for Nano win server#109

Merged
edsiper merged 5 commits intomasterfrom
cosmo0920-replace-nonexistence-apis-for-nano-win-server
Jul 14, 2025
Merged

os: dirent: Avoid to use PathIsDirectoryA and SHCreateDirectoryEx for Nano win server#109
edsiper merged 5 commits intomasterfrom
cosmo0920-replace-nonexistence-apis-for-nano-win-server

Conversation

@cosmo0920
Copy link
Copy Markdown
Contributor

@cosmo0920 cosmo0920 commented Jul 10, 2025

For Windows Nano Server supporting, we need to replace non existing APIs in Windows Nano Server.
At first, we need to remove the dependencies for PathIsDirectoryA and SHCreateDirectoryEx APIs.
In this PR, avoiding to use PathIsDirectoryA and SHCreateDirectoryEx.
This API is targeted for ordinary Windows platforms.
The full list of supported APIs in Windows Nano Server are:
https://learn.microsoft.com/en-us/previous-versions/windows/desktop/legacy/mt588480(v=vs.85)

This API is not existing in Windows Nano Server.

Signed-off-by: Hiroshi Hatake <hiroshi@chronosphere.io>
Signed-off-by: Hiroshi Hatake <hiroshi@chronosphere.io>
@cosmo0920 cosmo0920 force-pushed the cosmo0920-replace-nonexistence-apis-for-nano-win-server branch 4 times, most recently from 39f2c9c to 6730fe4 Compare July 10, 2025 10:23
@cosmo0920
Copy link
Copy Markdown
Contributor Author

Also, I fixed Windows workflows for unit testing.

Signed-off-by: Hiroshi Hatake <hiroshi@chronosphere.io>
Signed-off-by: Hiroshi Hatake <hiroshi@chronosphere.io>
@cosmo0920 cosmo0920 force-pushed the cosmo0920-replace-nonexistence-apis-for-nano-win-server branch from 6730fe4 to f10a6eb Compare July 10, 2025 11:01
@cosmo0920 cosmo0920 changed the title os: dirent: Replace nonexistence APIs for Nano win server os: dirent: Avoid to use PathIsDirectoryA for Nano win server Jul 10, 2025
Signed-off-by: Hiroshi Hatake <hiroshi@chronosphere.io>
@cosmo0920 cosmo0920 changed the title os: dirent: Avoid to use PathIsDirectoryA for Nano win server os: dirent: Avoid to use PathIsDirectoryA and SHCreateDirectoryEx for Nano win server Jul 11, 2025
@edsiper edsiper merged commit 6ee11e0 into master Jul 14, 2025
25 checks passed
@cosmo0920 cosmo0920 deleted the cosmo0920-replace-nonexistence-apis-for-nano-win-server branch July 15, 2025 02:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants