tests: cumulative_to_delta: Enable cumulative test case on Windows#11597
tests: cumulative_to_delta: Enable cumulative test case on Windows#11597
Conversation
Signed-off-by: Hiroshi Hatake <hiroshi@chronosphere.io>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughA test file's header dependencies are updated: the inclusion of Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Suggested labels
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
https://github.com/fluent/cmetrics/pull/258/changes and #11589 would be better to handle this issue. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: c36f9b2cd7
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| #include <cmetrics/cmt_map.h> | ||
| #include <cmetrics/cmt_metric.h> | ||
| #include <cfl/cfl_kvlist.h> | ||
| #include <fluent-bit/flb_compat.h> |
There was a problem hiding this comment.
Include flb_compat before cmetrics on Windows
On Windows this include is too late. tests/internal/cumulative_to_delta.c pulls in cmetrics/cmetrics.h first, and lib/cmetrics/include/cmetrics/cmetrics.h:45 -> cmt_compat.h:24-25 already includes <windows.h>. flb_compat.h then defines WIN32_LEAN_AND_MEAN and includes <winsock2.h>, which has to happen before <windows.h> to avoid the winsock.h/winsock2.h redefinition conflict. I checked tests/internal/CMakeLists.txt:117-123 and .github/workflows/call-windows-unit-tests.yaml:206-253; flb-it-cumulative_to_delta is built in the MSVC Windows unit-test job, so this patch still leaves the Windows build broken instead of enabling the test.
Useful? React with 👍 / 👎.
Another attempt of #11588.
Enter
[N/A]in the box, if an item is not applicable to your change.Testing
Before we can approve your change; please submit the following in a comment:
If this is a change to packaging of containers or native binaries then please confirm it works for all targets.
ok-package-testlabel to test for all targets (requires maintainer to do).Documentation
Backporting
Fluent Bit is licensed under Apache 2.0, by submitting this pull request I understand that this code will be released under the terms of that license.
Summary by CodeRabbit
Note: This release contains no user-facing changes. The updates are internal testing infrastructure improvements.