Skip to content

cmetrics: prevent appending .0 to scientific notation in bucket_value_to_string #11654

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Pigueiras wants to merge 1 commit into
base: master
Choose a base branch
from
+5 −1
Open

cmetrics: prevent appending .0 to scientific notation in bucket_value_to_string #11654

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion lib/cmetrics/src/cmt_encode_prometheus.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -373,7 +373,11 @@ static cfl_sds_t bucket_value_to_string(double val)
len = snprintf(str, 64, "%g", val);
cfl_sds_len_set(str, len);

if (!strchr(str, '.')) {
/*
* Append .0 only when there is no decimal point and the number
* is not in scientific notation.
*/
if (!strchr(str, '.') && !strchr(str, 'e')) {
cfl_sds_cat_safe(&str, ".0", 2);
}
Comment on lines 373 to 382
Copy link

Copilot AI Apr 1, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a regression unit test to cover this formatting behavior (large histogram bucket boundaries that are rendered in scientific notation should not get a trailing ".0" in the exported Prometheus le label). This helps prevent reintroducing malformed labels like "1e+08.0".

Copilot uses AI. Check for mistakes.
Copy link
Copy Markdown
Author

@Pigueiras Pigueiras Apr 1, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@copilot apply changes based on this feedback

Copy link
Copy Markdown
Contributor

@cosmo0920 cosmo0920 Apr 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks great but we need to register changes which intent to cmetrics into https://github.com/fluent/cmetrics. This is because under lib directory is handled as bundled libraries.


Expand Down