Skip to content

out_azure_kusto: stop logging federated and access tokens #12224

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tanmaya-panda1 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

out_azure_kusto: stop logging federated and access tokens #12224

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 9 additions & 4 deletions plugins/out_azure_kusto/azure_msiauth.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,9 @@ char *flb_azure_msiauth_token_get(struct flb_oauth2 *ctx)
flb_info("[azure msi auth] HTTP Status=%i", c->resp.status);
if (c->resp.payload_size > 0) {
if (c->resp.status == 200) {
flb_debug("[azure msi auth] payload:\n%s", c->resp.payload);
/* the payload carries the access token, never log its content */
flb_debug("[azure msi auth] token response received (%zu bytes)",
c->resp.payload_size);
}
else {
flb_info("[azure msi auth] payload:\n%s", c->resp.payload);
Expand Down Expand Up @@ -162,7 +164,9 @@ int flb_azure_workload_identity_token_get(struct flb_oauth2 *ctx, const char *to
return -1;
}

flb_info("[azure workload identity] after read token from file %s", federated_token);
/* the federated token is a credential, only log its size */
flb_debug("[azure workload identity] federated token read from %s (%zu bytes)",
token_file, flb_sds_len(federated_token));

/* Build the form data for token exchange *before* creating the client */
body = flb_sds_create_size(4096);
Expand Down Expand Up @@ -249,8 +253,9 @@ int flb_azure_workload_identity_token_get(struct flb_oauth2 *ctx, const char *to
/* c->body_buf = body; */
/* c->body_len = flb_sds_len(body); */

/* Add a debug log to verify the body content just before sending */
flb_debug("[azure workload identity] Sending request body (len=%zu): %s", flb_sds_len(body), body);
/* the body embeds the client assertion, never log its content */
flb_debug("[azure workload identity] sending token exchange request (body len=%zu)",
flb_sds_len(body));

/* Issue request */
ret = flb_http_do(c, &b_sent);
Expand Down
Loading