on resume check if the runout sensor actually exists before checking …#3
Open
pellcorp wants to merge 1 commit into
Open
on resume check if the runout sensor actually exists before checking …#3pellcorp wants to merge 1 commit into
pellcorp wants to merge 1 commit into
Conversation
…its enabled or filament detected
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…its enabled or filament detected
This is a simple change to check for the filament sensor being defined, I encountered an issue where the _CLIENT_VARIABLES had the runout_sensor config, but it had been commented out in the printer.cfg, this simple change allows for this easy misconfiguration without ruining a print due to a failed resume which can never be fixed without a restart.
The error we get when we try to resume if the runout_sensor is defined but does not match a actual filament sensor in the rest of printer.cfg is