Add input panel state event channel #142
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add InputPanelChannel to broadcast input panel state changes to Dart via "tizen/internal/inputpanel" event channel. States include "show", "hide", and "will_show".
Member
Author
|
/gemini review |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces an InputPanelChannel to broadcast input panel state changes to Dart. The implementation is generally well-structured, adding the necessary components for the new event channel. However, I've identified a critical memory safety issue in the InputPanelChannel destructor that could lead to a use-after-free bug. My review includes a specific code suggestion to address this problem.
seungsoo47
reviewed
Feb 4, 2026
xiaowei-guan
approved these changes
Feb 4, 2026
seungsoo47
approved these changes
Feb 4, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add InputPanelChannel to broadcast input panel state changes to Dart via "tizen/internal/inputpanel" event channel.
States include "show", "hide", and "will_show".