-
Notifications
You must be signed in to change notification settings - Fork 2
[Tizen] Re-implemented render external texture gl for impeller to avoid change FlutterOpenGLTexture and use deprecated api #23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…id change FlutterOpenGLTexture and use deprecated api
JSUYA
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the late review.
I left a comment. Please check it.
engine/src/flutter/shell/platform/embedder/embedder_external_texture_gl.cc
Outdated
Show resolved
Hide resolved
engine/src/flutter/shell/platform/embedder/embedder_external_texture_gl.cc
Show resolved
Hide resolved
engine/src/flutter/shell/platform/embedder/embedder_external_texture_gl.cc
Outdated
Show resolved
Hide resolved
engine/src/flutter/shell/platform/embedder/embedder_external_texture_gl.cc
Show resolved
Hide resolved
engine/src/flutter/shell/platform/embedder/embedder_external_texture_gl.h
Outdated
Show resolved
Hide resolved
JSUYA
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm a little worried because there are a lot of code diffs...
I think this patch has two advantages:
|
|
please rebase to 3.38.8 branch |
…id change FlutterOpenGLTexture and use deprecated api (flutter-tizen#23) We have supported render external texture gl for Impeller flutter-tizen/engine#368 But this PR has two issues: 1. It modify FlutterOpenGLTexture, it added additional variables, not a good design. ```C++ /// The pixel data buffer. const uint8_t* buffer; /// The size of pixel buffer. size_t buffer_size; /// Callback invoked that the gpu surface texture start binding. BoolCallback bind_callback; /// The type of the texture. FlutterGLImpellerTextureType impeller_texture_type; ``` 2. It uses Deprecated API ```C++ // Deprecated: use BlitPass::AddCopy instead. [[nodiscard]] bool SetContents(const uint8_t* contents, size_t length, size_t slice = 0, bool is_opaque = false); ``` So I tried to revert offical PR to render external gl for impeller flutter/engine#56277 But this PR doesn't work on Tizen platform, I think This PR may not have been verified. To avoid change FlutterOpenGLTexture and use deprecated api, so I re-implemented render external texture gl for impeller based on this offical PR. Fix flutter-tizen/embedder#131
We have supported render external texture gl for Impeller
flutter-tizen/engine#368
But this PR has two issues:
So I tried to revert offical PR to render external gl for impeller
flutter/engine#56277
But this PR doesn't work on Tizen platform, I think This PR may not have been verified.
To avoid change FlutterOpenGLTexture and use deprecated api, so I re-implemented render external texture gl for impeller based on this offical PR.
Fix flutter-tizen/embedder#131